Show how to start DB and the application in security-getting-started #26683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! Thank you for such a fast reaction! |
geoand
reviewed
Jul 13, 2022
| [source,bash] | ||
| ---- | ||
| docker run --rm=true --name security-getting-started -e POSTGRES_USER=quarkus \ | ||
| -e POSTGRES_PASSWORD=quarkus -e POSTGRES_DB=elytron_security_jpa \ |
There was a problem hiding this comment.
In application.properties we mention:
%prod.quarkus.datasource.jdbc.url=jdbc:postgresql:security_jpa
So it would be good to have these two aligned
There was a problem hiding this comment.
@geoand the actual quickstart uses elytron_jpa_security so I've fixed the doc itself to refer elytron_jpa_security, thanks
sberyozkin
force-pushed
the
getting_started_sec_doc_update
branch
from
23c4fd5 to
19c620d
Compare
geoand
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no information in this doc how to start DB and compile and start the application, so when users go to
Testing the curl or browserit can be missed that a DB is not running and the errors will happen.Hibernate ORM guide uses a
14.1image version so I copied that hereCC @MichalMaler