Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @All to inject ObjectMapperCustomizers #26660

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 11, 2022

This way, we are sure they are sorted by @priority.
And they can still be sorted by #getPriority(), this hasn't changed.

This way, we are sure they are sorted by @priority.
And they can still be sorted by #getPriority(), this hasn't changed.
@gsmet gsmet requested a review from geoand July 11, 2022 13:16
@quarkus-bot quarkus-bot bot added the area/jackson Issues related to Jackson (JSON library) label Jul 11, 2022
@gsmet
Copy link
Member Author

gsmet commented Jul 11, 2022

I used the same pattern for JsonbConfigCustomizer.

@Ladicek finally found a reference than instances in Instance would be sorted but given it's very clear in the @All contract, it doesn't hurt to use this one instead.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2022

Failing Jobs - Building 17c0497

Status Name Step Failures Logs Raw logs
✔️ Devtools Tests - JDK 11
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ Devtools Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.CustomSpringWebCodestartBuildIT.testBuild line 26 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status is zero] 
expected: 0

io.quarkus.devtools.codestarts.quarkus.CustomSpringWebCodestartBuildIT.testBuild line 26 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status is zero] 
expected: 0

@gsmet gsmet merged commit 864e707 into quarkusio:main Jul 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants