Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh codestart guide for Quarkiverse #26620

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Refresh codestart guide for Quarkiverse #26620

merged 1 commit into from
Jul 21, 2022

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jul 8, 2022

No description provided.

@ia3andy ia3andy force-pushed the update-codestart-doc branch 3 times, most recently from 15cef41 to 0de12f1 Compare July 11, 2022 12:47
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 11, 2022

@gsmet if you want to create a codestart,maybe it's a good opportunity to also validate this :)

@ia3andy ia3andy changed the title Refresh codestart guide Refresh codestart guide for Quarkiverse Jul 11, 2022
@ia3andy ia3andy requested a review from gsmet July 12, 2022 09:17
@gsmet
Copy link
Member

gsmet commented Jul 20, 2022

I'm having a look today.

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 20, 2022

@gsmet I also have this PR ready (I will add a section about it when this gets merged first): #26806

@ia3andy ia3andy force-pushed the update-codestart-doc branch from 1ec5ce2 to 5bc9c76 Compare July 21, 2022 13:12
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 21, 2022

ok squashed, just need you stamp @gsmet !

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 21, 2022

and thanks for the commit!

gsmet
gsmet approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, well, given the amount of work I put into it, I would have kept the commit but that's fine :).

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 21, 2022
@ia3andy ia3andy merged commit 74733cb into quarkusio:main Jul 21, 2022
@ia3andy ia3andy deleted the update-codestart-doc branch July 21, 2022 13:43
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 21, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 21, 2022
@ia3andy ia3andy mentioned this pull request Aug 23, 2022
Merged
@gsmet gsmet modified the milestones: 2.12.0.CR1, 2.11.3.Final Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.11.3.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@ia3andy @gsmet