Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear Reactive REST Client mocks after the test runs #26597

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Clear Reactive REST Client mocks after the test runs #26597

merged 2 commits into from
Jul 8, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 7, 2022

Fixes: #26594

@geoand geoand requested a review from michalszynkiewicz July 7, 2022 05:57
@geoand geoand mentioned this pull request Jul 7, 2022
Closed
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 7, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 7, 2022
@geoand geoand requested a review from famod July 7, 2022 13:32
@quarkus-bot

This comment has been minimized.

Sign in to view
famod
famod reviewed Jul 8, 2022
View reviewed changes
integration-tests/pom.xml Outdated Show resolved Hide resolved
famod
famod approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

That surefire config could even be set in build-parent, but we can do that later if required.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 8, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 8, 2022

Failing Jobs - Building fa7c426

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/mongodb-client/deployment 
! Skipped: extensions/liquibase-mongodb/deployment extensions/panache/mongodb-panache-common/deployment extensions/panache/mongodb-panache-kotlin/deployment and 8 more

📦 extensions/mongodb-client/deployment

✖ io.quarkus.mongodb.NamedReactiveMongoClientConfigTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

@geoand geoand merged commit 276e53a into quarkusio:main Jul 8, 2022
@geoand geoand deleted the #26594 branch July 8, 2022 13:08
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 8, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 8, 2022
@glefloch glefloch mentioned this pull request Jul 9, 2022
Closed
@gsmet gsmet modified the milestones: 2.11.0.CR1, 2.10.3.Final Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden left review comments

@famod famod famod approved these changes

@michalszynkiewicz michalszynkiewicz michalszynkiewicz approved these changes

@glefloch glefloch glefloch approved these changes

Assignees
No one assigned
Labels
area/core area/rest area/testing kind/bugfix
Projects
None yet
Milestone
2.10.3.Final
Development

Successfully merging this pull request may close these issues.

@InjectMock with reactive RestClient breaks the RestClient for subsequent tests
6 participants
@geoand @knutwannheden @glefloch @michalszynkiewicz @famod @gsmet