Fix tests lifecycle instance and methods annotated with AfterAll #26556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Jul 5, 2022
geoand
added
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
The issue was not completely fixed in the commit quarkusio@b306d8a. The problem was that we were clearing out all the outer instances and hence the current class was not matching with the current test instance. Fix quarkusio#25812
|
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items.
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
I still have to bisect to be sure, but I fear this has broken test isolation of some sort: |
|
Confirmed: When I revert this commit in the 2.10 branch then my tests don't fail anymore. |
|
AFAICS, the problem is that with the default |
|
A simple fix for that imminent problem is to add But it feels weird to leave so many outer instances in the queue when |
|
Can confirm that |
|
@ivansenic can you put together a reproducer? Thanks! |
It's quite hard to create a reproducer. When running tests one-by-one, for example in the IDE, it all works.. When running all of them We have tests using different profiles. A list of errors, maybe you find something helpful. Again all of those work when invoked standalone: |
|
The following hack works around the problem: import java.lang.reflect.Field;
import java.util.Collection;
import org.junit.jupiter.api.extension.AfterAllCallback;
import org.junit.jupiter.api.extension.ExtensionContext;
import io.quarkus.test.junit.QuarkusTest;
import io.quarkus.test.junit.QuarkusTestExtension;
/**
* Workaround for https://github.com/quarkusio/quarkus/pull/26556#issuecomment-1176798851 until proper fix is available.
*/
// This is not a QuarkusTestAfterAllCallback because the code must not run in a "Quarkus Runtime ClassLoader",
// we need the system CL (regular surefire) or deployment CL (continuous testing) instead.
public class QuarkusTestOuterInstancesWorkaround implements AfterAllCallback {
@Override
public void afterAll(final ExtensionContext context) throws Exception {
// after a toplevel QuarkusTest is done, make sure to clear outerInstances collection
// rationale: it might contain @Nested tests and will thus leak instances (as of 2.10.2.Final)
// note: checking for actual @Nested classes is not strictly required
if (context.getElement()
.filter(e -> e.isAnnotationPresent(QuarkusTest.class))
.isPresent()) {
try {
final Field field = QuarkusTestExtension.class.getDeclaredField("outerInstances");
field.setAccessible(true);
((Collection<?>) field.get(null)).clear();
} catch (final ReflectiveOperationException e) {
throw new IllegalStateException(e);
}
}
}
}(to be registered via Btw, in my case I'm also getting mock issues. I won't have much time to create a reproducer. |
This really makes a lot of sense. Will try to address this issue once I'm back from my sick leave days. |
|
@Sgitario oh, get well soon! Do you have an idea when that will be? No pressure, I'm just asking in case I find some time over the weekend. I tried to reproduce my problem by extending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was not completely fixed in the commit b306d8a.
The problem was that we were clearing out all the outer instances and hence the current class was not matching with the current test instance.
Fix #25812