Allow to override the Oracle JDBC metadata for native images also on Windows #26357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanne
added
area/persistence
geoand
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25954
Turns out the issue is that we include a "?" symbol in the regex to match both resources that we need excluded in the Oracle JDBC driver; this breaks the build on Windows as it causes something odd in parameter parsing.
We also can't quote it as GraalVM wouldn't accept a quoted regex - and we can't escape it.
We can workaround this problem by emitting two different sets of
--exclude-configoptions, one for each resource, rather than attempting to conflate both resources in a single regex.