Use variable for volume modifier because :Z does not play nicely on M1 #26327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
That's... interesting. Yes, the modifier was necessary for tests to pass locally (f0c38b9). No idea why it worked before; maybe it didn't, maybe it only worked on specific OS/distros.
Anyway, good to know I should use that volume.access.modifier property instead of adding :Z like there's no tomorrow :)
LGTM, thanks!
|
The moral of the story is that no good comes of having more than one platform architecture. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial resolution of #25428. See also discussion in #25648. It looks like sometime between me raising #25648, @yrodiere fixing the elastic search part with #25663 , and me trying again some time later, a volume mount got added to the elasticsearch docker config. As per #25805, volume mounts need a different access modifier on M1.
Symptom being fixed: Build fails with
setxattr … operation not supportedTo test:
TESTCONTAINERS_RYUK_DISABLED="true" ./mvnw -Dquickly -DskipTests=false -Dstart-containers -Dtest-containers -f integration-tests/logging-gelf