-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apicurio-common-rest-client-vertx
version
#26322
Conversation
Update `apicurio-common-rest-client-vertx` version to the most recent version. The current version (`0.1.9.Final`) does not work with some versions of apicurio. `0.1.11.Final` does, and is being used already. See https://github.com/quarkusio/quarkus-super-heroes/blob/280ba7d522d8f3a30a809cd92c8c89987276d8f9/rest-fights/pom.xml#L104-L122 Closes quarkusio#25378
@ozangunalp could you have a look at this small one? I'd like to backport it in time for 2.10.1.Final. Thanks! |
@edeandrea The change itself LGTM. Overall this is also related to #25814 pointed out by @pjgg. Between apicurio-registry 2.1.5 and 2.2.4 there has been a breaking change that makes Quarkus integration (via IIRC the update of So now it would seem there has been another breaking change? I'll run some checks using the existing IT to confirm different incompatibilities. |
@ozangunalp I can dig up the conversation I had with @carlesarnal if you'd like to review it. It was offline on an internal chat. Maybe updating to 0.1.9 is good enough? Maybe that's the incompatibility you're talking about. Do you know when the update to 0.1.9 happened? Was it after Quarkus 2.7.x? |
Hi there, I'll add some comments just for clarification.
What happened in this version was that a new request is being made in the client libraries so, if you run an older version of the server than the one used in the client libraries, it will fail.
No breaking changes here. A bug was introduced in
I hope this clarifies things a bit, and, if you have any questions or concerns, just ping me. Thanks! |
Ok thanks for the clarification @carlesarnal ! From the bom history I can tell |
@ozangunalp why are we targeting |
@gsmet we are not targeting 2.1.5 for the main, we are already depending on 2.2.4. In #25814 @pjgg was suggesting that we document this as a breaking change. Because using a recent version of Quarkus with apicurio registry version <= 2.1.5 you need to force a compatible version of |
@ozangunalp when you say "pinpoint" are you saying it's only a documentation thing to say after apicurio 2.1.5.Final there is a breaking change and that you need to force a version of |
It's a documentation thing to say if someone would like to use Quarkus with apicurio-registry version <= 2.1.5 they'll have to force versions of apicurio-rest-client. |
Got it. Thanks for clarifying. |
Would you like me to document it as part of this PR? |
@edeandrea actually no, before the explanation from @carlesarnal I thought that there was more to it. But I'll update the doc in a separate PR and close #25814. Thanks! |
Update
apicurio-common-rest-client-vertx
version to the most recent version. The current version (0.1.9.Final
) does not work with some versions of apicurio.0.1.11.Final
does, and is being used already. See https://github.com/quarkusio/quarkus-super-heroes/blob/280ba7d522d8f3a30a809cd92c8c89987276d8f9/rest-fights/pom.xml#L104-L122Specifically see #25378 (comment)
Closes #25378