Fix OidcBuildStep#findSecurityEventObservers()

[mkouba]

• this build step should consume RuntimeConfigSetupCompleteBuildItem
  because DefaultTenantConfigResolver injects a runtime config property
• resolves OIDC - NullPointerException #26236

[mkouba]

@beniaminp It would be great if you could test this PR with your app, i.e. clone the repo and run mvn clean install -Dquickly -T 1 and use the version 999-SNAPSHOT in your app.

[sberyozkin]

Thanks Martin

[sberyozkin]

Hi Martin @mkouba

I see

caused by: java.lang.IllegalArgumentException: Cannot consume an empty build item, use @Produce(class) on the build step method instead at io.quarkus.deployment.builditem.RuntimeConfigSetupCompleteBuildItem runtimeConfigComplete of public void io.quarkus.oidc.deployment.OidcBuildStep.findSecurityEventObservers(io.quarkus.oidc.runtime.OidcRecorder,io.quarkus.arc.deployment.SynthesisFinishedBuildItem,io.quarkus.deployment.builditem.RuntimeConfigSetupCompleteBuildItem) of class io.quarkus.oidc.deployment.OidcBuildStep

May be the item should still be returned instead of having void ?

[mkouba]

Hi Martin @mkouba

I see

caused by: java.lang.IllegalArgumentException: Cannot consume an empty build item, use @Produce(class) on the build step method instead at io.quarkus.deployment.builditem.RuntimeConfigSetupCompleteBuildItem runtimeConfigComplete of public void io.quarkus.oidc.deployment.OidcBuildStep.findSecurityEventObservers(io.quarkus.oidc.runtime.OidcRecorder,io.quarkus.arc.deployment.SynthesisFinishedBuildItem,io.quarkus.deployment.builditem.RuntimeConfigSetupCompleteBuildItem) of class io.quarkus.oidc.deployment.OidcBuildStep

May be the item should still be returned instead of having void ?

Not really. @Consume(RuntimeConfigSetupCompleteBuildItem.class) must be used instead of a RuntimeConfigSetupCompleteBuildItem parameter.

Oh and the error message is misleading.

[sberyozkin]

Thanks for taking care of it @mkouba :-)

[mkouba]

Thanks for taking care of it @mkouba :-)

yw :-)

[beniaminp]

Hey!
Thanks guys, this was really fast. I am starting to do a test now, I will let you know the outcome.

Thanks again!

[quarkus-bot]

Failing Jobs - Building b43a7be

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/cli 

📦 devtools/cli

✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project quarkus-cli: There was a timeout in the fork

[mkouba]

Hm, the timeout in the devtools/cli in JDK 17 is recurring. I can see the following line in the log:

2022-06-23T12:35:03.5482216Z [WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /home/runner/work/quarkus/quarkus/devtools/cli/target/surefire-reports/2022-06-23T10-48-28_225-jvmRun1.dumpstream

@gsmet @ebullient @aloubyansky does it ring a bell?

[sberyozkin]

Looks like unrelated