Allow overriding of app.openshift.io/runtime label #26285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iocanel
approved these changes
Jun 27, 2022
| @@ -246,7 +246,10 @@ public List<DecoratorBuildItem> createDecorators(ApplicationInfoBuildItem applic | |||
| }); | |||
|
|
|||
| result.add(new DecoratorBuildItem(OPENSHIFT, new ApplyImagePullPolicyDecorator(name, config.getImagePullPolicy()))); | |||
| result.add(new DecoratorBuildItem(OPENSHIFT, new AddLabelDecorator(name, OPENSHIFT_APP_RUNTIME, QUARKUS))); | |||
|
|
|||
| if (labels.stream().noneMatch(l -> l.getKey().equals(OPENSHIFT_APP_RUNTIME))) { | |||
There was a problem hiding this comment.
I really like it.
Ideally we should apply the same logic to all labels, annotations we add.
There was a problem hiding this comment.
Indeed! I'll try and go through the rest later on
There was a problem hiding this comment.
#26543 should take care of the rest of the labels
|
ZnjuHZnjuH |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jul 4, 2022
Follows up on quarkusio#26285
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jul 4, 2022
Follows up on quarkusio#26285
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Jul 18, 2022
Follows up on quarkusio#26285 (cherry picked from commit 80bd1c8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26273