Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narayana recovery manager service #26161

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Narayana recovery manager service #26161

merged 1 commit into from
Sep 14, 2022

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Jun 15, 2022

Fix #26160

@zhfeng zhfeng marked this pull request as draft June 15, 2022 14:14
@quarkus-bot quarkus-bot bot added the area/narayana Transactions / Narayana label Jun 15, 2022
@mmusgrov
Copy link
Contributor

I like this PR, thanks for adding it Amos.

I need some time to study it though. For example we need be able to test it to verify recovery. I was looking through the narayana ones [1], some of them require byteman others don't so we need to figure out which functionality we can test in Quarkus without byteman.

I would also like to compare and contrast it with how we configure recovery in WildFly [2]

[1] https://github.com/jbosstm/narayana/tree/master/ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery
[2] https://github.com/wildfly/wildfly/blob/main/transactions/src/main/java/org/jboss/as/txn/service/ArjunaRecoveryManagerService.java#L91

@zhfeng
Copy link
Contributor Author

zhfeng commented Jun 16, 2022

Thanks @mmusgrov for reviewing and I just borrow some codes from the narayana-spring-boot. We definitely need some tests to verify the recovery secenario.

Hmm, for byteman @adinn maybe have some ideas to enable it on Quarkus even in JVM mode.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jun 16, 2022

And it looks like there is an issue for byteman extension #2263

@zhfeng zhfeng force-pushed the narayana_recovery_service branch from f1f7122 to ee32aa1 Compare September 6, 2022 09:53
@mmusgrov
Copy link
Contributor

mmusgrov commented Sep 6, 2022

Thanks for the last change @zhfeng
Do you know who will be adding tests for this PR - is it something you need to do or is it something for the narayana team?

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 6, 2022

Hi @mmusgrov , I think we can always work together to add the tests. It could leverage https://github.com/jbosstm/quickstart/tree/master/spring/narayana-spring-boot to do the recovery test manually without byteman. But I did not find a way to restart a quarkus application after crashing just like we did in Arqullian container, e.g. https://github.com/jbosstm/narayana/blob/master/XTS/localjunit/crash-recovery-tests/src/test/java/com/arjuna/qa/junit/BaseCrashTest.java#L192

@zhfeng zhfeng force-pushed the narayana_recovery_service branch 2 times, most recently from b17da6e to ee12e64 Compare September 8, 2022 03:44
@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 8, 2022

Hi @mmusgrov ,

I just create a simple project [1] to demonstrates the crash recovery. Please can you verify it on your side? and you need to rebuild the quarkus with the changes in this PR.

Thanks,

[1] https://github.com/zhfeng/quarkus-narayana-crash-recovery

@zhfeng zhfeng force-pushed the narayana_recovery_service branch from ee12e64 to bf42970 Compare September 8, 2022 16:19
@zhfeng zhfeng force-pushed the narayana_recovery_service branch from bf42970 to 52c8f4d Compare September 9, 2022 16:07
@zhfeng zhfeng marked this pull request as ready for review September 9, 2022 16:09
@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 9, 2022

@mmusgrov can you review these changes? I'd test it manually both work in JVM and native mode.

@quarkus-bot

This comment has been minimized.

Sign in to view
mmusgrov
mmusgrov approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhfeng for this vital contribution.

Thanks also for providing your git branch for the manual recovery test which I have verified using your README. If we can get some input from the quarkus team to help us test crash recovery we should add some tests (basically we need to be able to crash and restart the test container and then verify that transactions are recovered). Amos did you approach anyone about this, @gastaldi any idea who we can ping to get some help with automating crash recovery testing?

...a/runtime/src/main/java/io/quarkus/narayana/jta/runtime/TransactionManagerConfiguration.java
@ConfigItem(defaultValue = "com.arjuna.ats.internal.jta.recovery.arjunacore.JTATransactionLogXAResourceOrphanFilter," +
"com.arjuna.ats.internal.jta.recovery.arjunacore.JTANodeNameXAResourceOrphanFilter," +
"com.arjuna.ats.internal.jta.recovery.arjunacore.JTAActionStatusServiceXAResourceOrphanFilter")
public List<String> xaResourceOrphanFilters;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I agree, I think this is all we need for recovering orphaned XA branches.

mmusgrov
mmusgrov reviewed Sep 13, 2022
View reviewed changes
...a/runtime/src/main/java/io/quarkus/narayana/jta/runtime/TransactionManagerConfiguration.java
*/
@ConfigItem(defaultValue = "com.arjuna.ats.internal.arjuna.recovery.AtomicActionRecoveryModule," +
"com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule")
public List<String> recoveryModules;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I agree, I think this is all we need for recovering XA resources.

@gastaldi
Copy link
Contributor

any idea who we can ping to get some help with automating crash recovery testing?

@mmusgrov It sounds like a feature request to our testing harness library, mind opening a new issue with the expected behavior for this use case?

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 14, 2022 •
edited
Loading

Thanks @gastaldi I open #27911 to add crash recovery support in testing. Anyway, can we merge this PR into the coming 2.13 release since it can verify the recovery manually at least?

@gastaldi gastaldi merged commit bc5fb5a into quarkusio:main Sep 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 14, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 14, 2022
@gastaldi
Copy link
Contributor

@zhfeng sure, I just merged because @mmusgrov approved 😉
Thanks for the PR!

Dairdevil pushed a commit to Dairdevil/quarkus that referenced this pull request Sep 14, 2022
Squashed commit of the following:
d4305e3 
commit 62657c0
Merge: f7b6773 2928919
Author: Alasdair Preston <[email protected]>
Date:   Wed Sep 14 11:08:51 2022 +0100

    Merge branch 'bugfix/26587-openshift-route-named-port' of github.com:Dairdevil/quarkus into bugfix/26587-openshift-route-named-port

commit f7b6773
Author: Michal Vavřík <[email protected]>
Date:   Tue Sep 13 21:10:54 2022 +0200

    Generate Quarkus Maven Plugin Config Docs

    resolves: quarkusio#1204

commit 9bfd447
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Sep 9 21:09:37 2022 +0000

    Bump kafka3.version from 3.2.1 to 3.2.2

    Bumps `kafka3.version` from 3.2.1 to 3.2.2.

    Updates `kafka-clients` from 3.2.1 to 3.2.2

    Updates `kafka-streams` from 3.2.1 to 3.2.2

    Updates `kafka-streams-test-utils` from 3.2.1 to 3.2.2

    Updates `kafka_2.13` from 3.2.1 to 3.2.2

    ---
    updated-dependencies:
    - dependency-name: org.apache.kafka:kafka-clients
      dependency-type: direct:production
      update-type: version-update:semver-patch
    - dependency-name: org.apache.kafka:kafka-streams
      dependency-type: direct:production
      update-type: version-update:semver-patch
    - dependency-name: org.apache.kafka:kafka-streams-test-utils
      dependency-type: direct:production
      update-type: version-update:semver-patch
    - dependency-name: org.apache.kafka:kafka_2.13
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit ebc0112
Author: Sanne Grinovero <[email protected]>
Date:   Tue Sep 13 17:28:18 2022 +0100

    Transform DB2 driver to Jakarta APIs

commit 3bc918c
Author: Réda Housni Alaoui <[email protected]>
Date:   Fri Jul 22 22:15:40 2022 +0200

    Quarkus NativeImageBuildStep fails with perm denied with docker rootless

commit 604bab7
Author: Auri Munoz <[email protected]>
Date:   Fri Sep 9 16:02:49 2022 +0200

    update Stork version to align with k8s client 6.x

    Related to quarkusio#6588

commit 59c4822
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 13 23:01:39 2022 +0000

    Bump actions/download-artifact from 1 to 3

    Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 1 to 3.
    - [Release notes](https://github.com/actions/download-artifact/releases)
    - [Commits](actions/download-artifact@v1...v3)

    ---
    updated-dependencies:
    - dependency-name: actions/download-artifact
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit d1c8566
Author: Zheng Feng <[email protected]>
Date:   Wed Jun 15 08:58:13 2022 +0800

    Improve Narayana recovery manager service and integrate it with agroal

commit beab85f
Author: Holly Cummins <[email protected]>
Date:   Fri Sep 9 20:26:25 2022 +0100

    Cross-link to quarkiverse wiki

commit 701b930
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 13 09:55:11 2022 +0000

    Bump liquibase.version from 4.15.0 to 4.16.0

    Bumps `liquibase.version` from 4.15.0 to 4.16.0.

    Updates `liquibase-core` from 4.15.0 to 4.16.0
    - [Release notes](https://github.com/liquibase/liquibase/releases)
    - [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt)
    - [Commits](liquibase/liquibase@v4.15.0...v4.16.0)

    Updates `liquibase-mongodb` from 4.15.0 to 4.16.0
    - [Release notes](https://github.com/liquibase/liquibase-mongodb/releases)
    - [Changelog](https://github.com/liquibase/liquibase-mongodb/blob/main/RELEASE.md)
    - [Commits](liquibase/liquibase-mongodb@liquibase-mongodb-4.15.0...liquibase-mongodb-4.16.0)

    ---
    updated-dependencies:
    - dependency-name: org.liquibase:liquibase-core
      dependency-type: direct:production
      update-type: version-update:semver-minor
    - dependency-name: org.liquibase.ext:liquibase-mongodb
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 22c71e9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Sep 12 21:22:57 2022 +0000

    Bump micrometer-bom from 1.9.3 to 1.9.4

    Bumps [micrometer-bom](https://github.com/micrometer-metrics/micrometer) from 1.9.3 to 1.9.4.
    - [Release notes](https://github.com/micrometer-metrics/micrometer/releases)
    - [Commits](micrometer-metrics/micrometer@v1.9.3...v1.9.4)

    ---
    updated-dependencies:
    - dependency-name: io.micrometer:micrometer-bom
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit ebf6e16
Author: Martin Kouba <[email protected]>
Date:   Tue Sep 13 14:19:16 2022 +0200

    ArC - support non-producer methods annotated with @startup

    - resolves quarkusio#11710

commit 5b677dc
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 15:25:04 2022 +0300

    Properly support generic bounds for ParamConverterProvider classes

    Fixes: quarkusio#27892

commit f2382b1
Author: Holly Cummins <[email protected]>
Date:   Tue Sep 13 15:22:21 2022 +0100

    Allow some PRs to run workflows, even when repo settings require approval for all non-committer PRs

commit 492b184
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:45:04 2022 +0200

    Add more info about releasing to CONTRIBUTING.md

commit f6053e0
Author: Réda Housni Alaoui <[email protected]>
Date:   Thu Aug 4 21:36:36 2022 +0200

    Document the release process

    Fix quarkusio#26901

commit db141a2
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 14:50:18 2022 +0300

    Ensure that Mongo DNS lookup does not happen on the event loop

    This is done by performing the DNS lookup at application startup
    and caching the results

    Fixes: quarkusio#27627

commit 8baab4e
Author: Katia Aresti <[email protected]>
Date:   Fri Sep 9 12:33:14 2022 +0200

    Create Infinispan caches on first access with the minimal config if they don't exist

commit 24bcf7c
Author: Ozan Gunalp <[email protected]>
Date:   Tue Aug 23 19:37:47 2022 +0300

    Kafka dev ui as a dev console route

    minor fixes for UI

commit 73d2c6f
Author: Emiliia Nesterovych <[email protected]>
Date:   Wed Aug 3 13:17:41 2022 +0200

    extend kafka dev ui

commit d27a75a
Author: Oleksiy Lukin <[email protected]>
Date:   Mon Aug 1 12:45:58 2022 +0200

    implement basic kafka dev ui

commit 11e984f
Author: Roberto Cortez <[email protected]>
Date:   Mon Sep 5 17:43:03 2022 +0100

    Properly generate documents from config groups in ConfigMapping

commit 36f1509
Author: xstefank <[email protected]>
Date:   Fri Sep 9 11:07:19 2022 +0200

    Upgrade SmallRye Health to 3.3.0

commit 6fd7f1c
Author: Tomas Hofman <[email protected]>
Date:   Fri Sep 9 14:54:02 2022 +0200

    Rest client config: Remove incorrect note about the proxyAddress property being only applicable to reactive clients

commit efddfeb
Author: Tomas Hofman <[email protected]>
Date:   Fri Sep 9 14:46:49 2022 +0200

    Add RestClientBuilder factories

    These factories should make it easier for developers to obtain a
    RestClientBuilder instance preconfigured according to current
    application config. The builder can be further tweaked and then used to
    programatically build a rest client proxy.

commit 28e2306
Author: Tomas Hofman <[email protected]>
Date:   Thu Sep 8 14:47:56 2022 +0200

    Rest client classic: make configuration methods in RestClientBase protected

    This is to accommodate kogito extension that accesses these methods.

commit 8e4d836
Author: Loïc Mathieu <[email protected]>
Date:   Wed Aug 31 11:13:57 2022 +0200

    Improve command mode guide

commit a982c88
Author: vsevel <[email protected]>
Date:   Tue Sep 13 09:52:25 2022 +0200

    Bump jboss-logmanager 1.1.1

commit 1bfd5e5
Author: Georgios Andrianakis <[email protected]>
Date:   Mon Sep 12 10:16:13 2022 +0300

    Return proper response code when an HTTP request contains an invalid Q value

    Closes: quarkusio#27852

commit af22e7c
Author: Clement Escoffier <[email protected]>
Date:   Tue Sep 13 10:27:57 2022 +0200

    Use default host and port when the service instance does not set them

commit 7cb775e
Author: Clement Escoffier <[email protected]>
Date:   Tue Sep 13 09:03:49 2022 +0200

    Fix request context leak in the Funqy Knative runtime.

commit a861e54
Author: Georgios Andrianakis <[email protected]>
Date:   Mon Sep 12 13:13:03 2022 +0300

    Allow setting a custom logging filter on logging handlers

    Resolves: quarkusio#25981

commit 2928919
Merge: 71ae072 9402450
Author: Alasdair Preston <[email protected]>
Date:   Wed Sep 14 11:04:37 2022 +0100

    Merge branch 'main' of github.com:Dairdevil/quarkus into bugfix/26587-openshift-route-named-port

commit 9402450
Merge: b963b7e dba1b1e
Author: Guillaume Smet <[email protected]>
Date:   Wed Sep 14 10:42:59 2022 +0200

    Merge pull request quarkusio#26369 from michalvavrik/feature/mvn-docs-generator

    Generate Quarkus Maven Plugin Config Docs

commit b963b7e
Merge: 3ab09ab 06caa54
Author: Clement Escoffier <[email protected]>
Date:   Wed Sep 14 10:32:57 2022 +0200

    Merge pull request quarkusio#27847 from quarkusio/dependabot/maven/kafka3.version-3.2.2

    Bump kafka3.version from 3.2.1 to 3.2.2

commit 3ab09ab
Merge: 37f266d ec6d2cf
Author: Guillaume Smet <[email protected]>
Date:   Wed Sep 14 10:29:42 2022 +0200

    Merge pull request quarkusio#27910 from Sanne/DB2JakartaNative

    Allow transforming the DB2 JDBC driver to Jakarta APIs during Augmentation

commit 37f266d
Merge: 6e10b21 565f4d4
Author: Foivos <[email protected]>
Date:   Wed Sep 14 11:18:52 2022 +0300

    Merge pull request quarkusio#26892 from Cosium/fix-26890

    Quarkus NativeImageBuildStep fails with perm denied with docker rootless

commit 71ae072
Author: Alasdair Preston <[email protected]>
Date:   Tue Sep 13 11:23:38 2022 +0100

        Override target port used when creating openshift route

commit ec6d2cf
Author: Sanne Grinovero <[email protected]>
Date:   Tue Sep 13 17:28:18 2022 +0100

    Transform DB2 driver to Jakarta APIs

commit 6e10b21
Merge: 6049d8f eee3dc2
Author: Georgios Andrianakis <[email protected]>
Date:   Wed Sep 14 10:21:17 2022 +0300

    Merge pull request quarkusio#27839 from aureamunoz/upgrade-stork-version

    Update Stork version to align with k8s client 6.x

commit 6049d8f
Merge: bc5fb5a d90af0f
Author: Guillaume Smet <[email protected]>
Date:   Wed Sep 14 08:16:16 2022 +0200

    Merge pull request quarkusio#27909 from quarkusio/dependabot/github_actions/actions/download-artifact-3

    Bump actions/download-artifact from 1 to 3

commit bc5fb5a
Merge: 6461dd5 52c8f4d
Author: George Gastaldi <[email protected]>
Date:   Wed Sep 14 01:04:18 2022 -0300

    Merge pull request quarkusio#26161 from zhfeng/narayana_recovery_service

commit d90af0f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 13 23:01:39 2022 +0000

    Bump actions/download-artifact from 1 to 3

    Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 1 to 3.
    - [Release notes](https://github.com/actions/download-artifact/releases)
    - [Commits](actions/download-artifact@v1...v3)

    ---
    updated-dependencies:
    - dependency-name: actions/download-artifact
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit dba1b1e
Author: Michal Vavřík <[email protected]>
Date:   Tue Sep 13 21:10:54 2022 +0200

    Generate Quarkus Maven Plugin Config Docs

    resolves: quarkusio#1204

commit 565f4d4
Author: Réda Housni Alaoui <[email protected]>
Date:   Fri Jul 22 22:15:40 2022 +0200

    Quarkus NativeImageBuildStep fails with perm denied with docker rootless

commit 6461dd5
Merge: 5c5e7ce 223b6cc
Author: George Gastaldi <[email protected]>
Date:   Tue Sep 13 15:14:33 2022 -0300

    Merge pull request quarkusio#27846 from holly-cummins/holly-wiki-links

commit 223b6cc
Author: Holly Cummins <[email protected]>
Date:   Fri Sep 9 20:26:25 2022 +0100

    Cross-link to quarkiverse wiki

commit 5c5e7ce
Merge: 0ddffcf b8405f3
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 19:17:29 2022 +0200

    Merge pull request quarkusio#27863 from quarkusio/dependabot/maven/liquibase.version-4.16.0

    Bump liquibase.version from 4.15.0 to 4.16.0

commit 0ddffcf
Merge: a675c2e eaedc32
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 19:16:32 2022 +0200

    Merge pull request quarkusio#27880 from quarkusio/dependabot/maven/io.micrometer-micrometer-bom-1.9.4

    Bump micrometer-bom from 1.9.3 to 1.9.4

commit a675c2e
Merge: 329af5a 78191c0
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 19:16:15 2022 +0200

    Merge pull request quarkusio#27897 from mkouba/issue-11710

    Support non-producer methods annotated with @startup

commit 329af5a
Merge: 20cea48 67eb7b5
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 18:40:25 2022 +0300

    Merge pull request quarkusio#27898 from geoand/quarkusio#27892

    Properly support generic bounds for ParamConverterProvider classes

commit 20cea48
Merge: 602ed25 fd811f3
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 16:28:03 2022 +0200

    Merge pull request quarkusio#27899 from holly-cummins/holly-enable-workflow-bot

    Auto-approve workflow runs from established contributors or low-risk files

commit fd811f3
Author: Holly Cummins <[email protected]>
Date:   Tue Sep 13 15:22:21 2022 +0100

    Allow some PRs to run workflows, even when repo settings require approval for all non-committer PRs

commit 602ed25
Merge: 20d9c4f e3f4dfe
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 16:19:20 2022 +0200

    Merge pull request quarkusio#27142 from reda-alaoui/patch-1

    Document the release process

commit 20d9c4f
Merge: c04644b e04b11f
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 16:10:58 2022 +0300

    Merge pull request quarkusio#27896 from geoand/quarkusio#27627

    Ensure that Mongo DNS lookup does not happen on the event loop

commit c04644b
Merge: 5e6a3c9 c18c4d0
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 16:03:31 2022 +0300

    Merge pull request quarkusio#27838 from karesti/minimal-viable-config

    Create Infinispan caches on first access with the minimal config

commit e3f4dfe
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:45:04 2022 +0200

    Add more info about releasing to CONTRIBUTING.md

commit a9e0f55
Author: Réda Housni Alaoui <[email protected]>
Date:   Thu Aug 4 21:36:36 2022 +0200

    Document the release process

    Fix quarkusio#26901

commit 67eb7b5
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 15:25:04 2022 +0300

    Properly support generic bounds for ParamConverterProvider classes

    Fixes: quarkusio#27892

commit 78191c0
Author: Martin Kouba <[email protected]>
Date:   Tue Sep 13 14:19:16 2022 +0200

    ArC - support non-producer methods annotated with @startup

    - resolves quarkusio#11710

commit 5e6a3c9
Merge: 7cfcecc 1750554
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:29:35 2022 +0200

    Merge pull request quarkusio#26998 from alukin/feature/kafka-client-dev-ui-squashed

    Introduce a Kafka Client DevUI component

commit 7cfcecc
Merge: 599d415 01499ac
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:22:45 2022 +0200

    Merge pull request quarkusio#27756 from radcortez/fix-27668

    Properly generate documents from config groups in ConfigMapping

commit 599d415
Merge: 45e97cc 07fee83
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:20:53 2022 +0200

    Merge pull request quarkusio#27829 from xstefank/health-3.3.0

    Upgrade SmallRye Health to 3.3.0

commit 45e97cc
Merge: 7e79e40 58c0966
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:20:11 2022 +0200

    Merge pull request quarkusio#27810 from TomasHofman/kogito-visibility-fix

    Rest client classic: revert to package private visibility for configuration methods

commit 7e79e40
Merge: 469fd21 6e121b2
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:18:43 2022 +0200

    Merge pull request quarkusio#27539 from loicmathieu/command-mode-guide

    Improve command mode guide

commit c18c4d0
Author: Katia Aresti <[email protected]>
Date:   Fri Sep 9 12:33:14 2022 +0200

    Create Infinispan caches on first access with the minimal config if they don't exist

commit 469fd21
Merge: 89fc74f c3250e0
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 14:14:27 2022 +0200

    Merge pull request quarkusio#27890 from vsevel/jboss-logmanager-1.1.1

    Bump jboss-logmanager 1.1.1

commit c3250e0
Author: vsevel <[email protected]>
Date:   Tue Sep 13 09:52:25 2022 +0200

    Bump jboss-logmanager 1.1.1

commit e04b11f
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 14:50:18 2022 +0300

    Ensure that Mongo DNS lookup does not happen on the event loop

    This is done by performing the DNS lookup at application startup
    and caching the results

    Fixes: quarkusio#27627

commit 89fc74f
Merge: 136ed6f f8b761c
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 13:47:28 2022 +0200

    Merge pull request quarkusio#27859 from geoand/quarkusio#27852

    Return proper response code when an HTTP request contains an invalid Q value

commit 136ed6f
Merge: 9de09fa 66a11c4
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 13:46:40 2022 +0200

    Merge pull request quarkusio#27891 from cescoffier/stork-filter-handle-unset-host-and-port

    Use default host and port when the service instance does not set them

commit 9de09fa
Merge: 709f2b0 af89f4f
Author: Guillaume Smet <[email protected]>
Date:   Tue Sep 13 13:21:00 2022 +0200

    Merge pull request quarkusio#27885 from cescoffier/fix-knative-funqy-context-issue

    Fix request context leak in the Funqy Knative runtime

commit 709f2b0
Merge: b60ad38 3fb466f
Author: Georgios Andrianakis <[email protected]>
Date:   Tue Sep 13 13:43:16 2022 +0300

    Merge pull request quarkusio#27864 from geoand/quarkusio#25981

    Allow setting a custom logging filter on logging handlers

commit b8405f3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 13 09:55:11 2022 +0000

    Bump liquibase.version from 4.15.0 to 4.16.0

    Bumps `liquibase.version` from 4.15.0 to 4.16.0.

    Updates `liquibase-core` from 4.15.0 to 4.16.0
    - [Release notes](https://github.com/liquibase/liquibase/releases)
    - [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt)
    - [Commits](liquibase/liquibase@v4.15.0...v4.16.0)

    Updates `liquibase-mongodb` from 4.15.0 to 4.16.0
    - [Release notes](https://github.com/liquibase/liquibase-mongodb/releases)
    - [Changelog](https://github.com/liquibase/liquibase-mongodb/blob/main/RELEASE.md)
    - [Commits](liquibase/liquibase-mongodb@liquibase-mongodb-4.15.0...liquibase-mongodb-4.16.0)

    ---
    updated-dependencies:
    - dependency-name: org.liquibase:liquibase-core
      dependency-type: direct:production
      update-type: version-update:semver-minor
    - dependency-name: org.liquibase.ext:liquibase-mongodb
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 66a11c4
Author: Clement Escoffier <[email protected]>
Date:   Tue Sep 13 10:27:57 2022 +0200

    Use default host and port when the service instance does not set them

commit af89f4f
Author: Clement Escoffier <[email protected]>
Date:   Tue Sep 13 09:03:49 2022 +0200

    Fix request context leak in the Funqy Knative runtime.

commit 3fb466f
Author: Georgios Andrianakis <[email protected]>
Date:   Mon Sep 12 13:13:03 2022 +0300

    Allow setting a custom logging filter on logging handlers

    Resolves: quarkusio#25981

commit eaedc32
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Sep 12 21:22:57 2022 +0000

    Bump micrometer-bom from 1.9.3 to 1.9.4

    Bumps [micrometer-bom](https://github.com/micrometer-metrics/micrometer) from 1.9.3 to 1.9.4.
    - [Release notes](https://github.com/micrometer-metrics/micrometer/releases)
    - [Commits](micrometer-metrics/micrometer@v1.9.3...v1.9.4)

    ---
    updated-dependencies:
    - dependency-name: io.micrometer:micrometer-bom
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 1750554
Author: Ozan Gunalp <[email protected]>
Date:   Tue Aug 23 19:37:47 2022 +0300

    Kafka dev ui as a dev console route

    minor fixes for UI

commit 119a046
Author: Emiliia Nesterovych <[email protected]>
Date:   Wed Aug 3 13:17:41 2022 +0200

    extend kafka dev ui

commit 1a8b36b
Author: Oleksiy Lukin <[email protected]>
Date:   Mon Aug 1 12:45:58 2022 +0200

    implement basic kafka dev ui

commit 58c0966
Author: Tomas Hofman <[email protected]>
Date:   Fri Sep 9 14:54:02 2022 +0200

    Rest client config: Remove incorrect note about the proxyAddress property being only applicable to reactive clients

commit c0e11c6
Author: Tomas Hofman <[email protected]>
Date:   Fri Sep 9 14:46:49 2022 +0200

    Add RestClientBuilder factories

    These factories should make it easier for developers to obtain a
    RestClientBuilder instance preconfigured according to current
    application config. The builder can be further tweaked and then used to
    programatically build a rest client proxy.

commit 07fee83
Author: xstefank <[email protected]>
Date:   Fri Sep 9 11:07:19 2022 +0200

    Upgrade SmallRye Health to 3.3.0

commit f8b761c
Author: Georgios Andrianakis <[email protected]>
Date:   Mon Sep 12 10:16:13 2022 +0300

    Return proper response code when an HTTP request contains an invalid Q value

    Closes: quarkusio#27852

commit eee3dc2
Author: Auri Munoz <[email protected]>
Date:   Fri Sep 9 16:02:49 2022 +0200

    update Stork version to align with k8s client 6.x

    Related to quarkusio#6588

commit 06caa54
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Sep 9 21:09:37 2022 +0000

    Bump kafka3.version from 3.2.1 to 3.2.2

    Bumps `kafka3.version` from 3.2.1 to 3.2.2.

    Updates `kafka-clients` from 3.2.1 to 3.2.2

    Updates `kafka-streams` from 3.2.1 to 3.2.2

    Updates `kafka-streams-test-utils` from 3.2.1 to 3.2.2

    Updates `kafka_2.13` from 3.2.1 to 3.2.2

    ---
    updated-dependencies:
    - dependency-name: org.apache.kafka:kafka-clients
      dependency-type: direct:production
      update-type: version-update:semver-patch
    - dependency-name: org.apache.kafka:kafka-streams
      dependency-type: direct:production
      update-type: version-update:semver-patch
    - dependency-name: org.apache.kafka:kafka-streams-test-utils
      dependency-type: direct:production
      update-type: version-update:semver-patch
    - dependency-name: org.apache.kafka:kafka_2.13
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 52c8f4d
Author: Zheng Feng <[email protected]>
Date:   Wed Jun 15 08:58:13 2022 +0800

    Improve Narayana recovery manager service and integrate it with agroal

commit 23d2600
Author: Tomas Hofman <[email protected]>
Date:   Thu Sep 8 14:47:56 2022 +0200

    Rest client classic: make configuration methods in RestClientBase protected

    This is to accommodate kogito extension that accesses these methods.

commit 01499ac
Author: Roberto Cortez <[email protected]>
Date:   Mon Sep 5 17:43:03 2022 +0100

    Properly generate documents from config groups in ConfigMapping

commit 6e121b2
Author: Loïc Mathieu <[email protected]>
Date:   Wed Aug 31 11:13:57 2022 +0200

    Improve command mode guide
@mmusgrov
Copy link
Contributor

any idea who we can ping to get some help with automating crash recovery testing?

@mmusgrov It sounds like a feature request to our testing harness library, mind opening a new issue with the expected behavior for this use case?

I have created #27958 to track the feature request.

@Postremus Postremus mentioned this pull request Sep 16, 2022
Closed
@gsmet
Copy link
Member

gsmet commented Sep 16, 2022

@mmusgrov @zhfeng we had reports of people complaining that Quarkus was now creating ObjectStore directories in the root modules of applications under test.

This is definitely not something we want.
I'm also a bit unsure of if this new feature should be enabled by default or if it should be protected by a config boolean.

@Sanne what's your take on this?

From my side, if we don't have a fix for the ObjectStore directories being created where they shouldn't, I will have to revert this patch for 2.13 as that's really not something we can afford (especially since there's a good chance users will commit the ObjectStores to their repositories without noticing).

I release 2.13.0.Final on Wednesday so we need a fix in by then or I will have to revert this patch in 2.13 (and we can keep it in main but we will need a fix before 2.14 is out).

This was referenced Sep 16, 2022
Closed
Closed
@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 16, 2022

@gsmet I think it can be fixed by set the default value of objectStoreDirectory to target/ObjectStore. And I think the crash recovery capability is very important to keep the data consistence during transactions. We could introduce an option enableRecovery but default valude should be true, and if users set it to false, it should print a WARN message. @mmusgrov WDYT?

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 16, 2022

Fix for ObjectStore #28014

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 16, 2022

I just wonder why we should filter out the recovery starting messages in #27987 ?

@gsmet
Copy link
Member

gsmet commented Sep 16, 2022

@zhfeng we work hard to keep the Quarkus startup log free from any noise. If we had every service of every extension logging two lines for the startup, we would end up with dozens of lines. We don't want that in Quarkus. We log if something goes wrong.

@gsmet
Copy link
Member

gsmet commented Sep 16, 2022

@zhfeng I commented in your PR. I don't think that it's that simple. Otherwise I would have provided a PR myself :).

@gsmet
Copy link
Member

gsmet commented Sep 16, 2022

@zhfeng is this recovery service needed even if XA is not enabled?

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 17, 2022

Thanks @gsmet OK, I better understand the problem now.

@zhfeng is this recovery service needed even if XA is not enabled?

No, I think it should be needed when XA enabled. such as

quarkus.datasource.jdbc.transactions=XA

or involve other XAResource in the transaction. @mmusgrov correct me if I'm wrong.

So it makes sense to introduce a config enableXARecovery to start the recovery service on startup. The default value could be false but if users enable XA in the application like above datasource configuration. It should

quarkus.transaction-manager.enable-xa-recovery=true

otherwise, they will have a risk to lose the data consistency when the application crash happens. And yeah, if they enable-xa-recovery, the ObjectStore will be created. Is it still a problem?

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 17, 2022

#28025 to introduce enableXARecovery

@zhfeng
Copy link
Contributor Author

zhfeng commented Sep 19, 2022

I update the objectStoreDirecotry to use OutputTargetBuildItem as default value, see ca64491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusgrov mmusgrov mmusgrov approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/agroal area/narayana Transactions / Narayana kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Improve recovery manager in quarkus-narayana-jta extension
4 participants
@zhfeng @mmusgrov @gastaldi @gsmet