Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage artifacts used by us and other Quarkus Platform participants #26069

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jun 12, 2022

Fix #26068
Fix #26071
Fix #26072
Fix #26073
Fix #26087

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jun 12, 2022
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 12, 2022

See also https://issues.redhat.com/browse/QUARKUS-2213

A backport to 2.7 would be nice

bom/application/pom.xml Outdated Show resolved Hide resolved
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 13, 2022

907de33:

  • Rebased
  • Added the missing javassist constraint

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 13, 2022

a30d892:

  • Ban javassist instead of managing it.

@quarkus-bot

This comment has been minimized.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 13, 2022

Is this good to merge now, @gastaldi @gsmet ?

@geoand
Copy link
Contributor

geoand commented Jun 14, 2022

The title of the PR looks misleading based on the number of changes of changes it introduces

@ppalaga ppalaga changed the title Manage com.squareup.okio:okio Manage artifacts used by us and other Quarkus Platform participants Jun 14, 2022
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 14, 2022

The title of the PR looks misleading based on the number of changes of changes it introduces

Renamed

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but let's get another CI run to be on the safe side.

@gsmet
Copy link
Member

gsmet commented Jun 14, 2022

I triggered a new CI run.

@quarkus-bot

This comment has been minimized.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 17, 2022

@gsmet Do I need to investigate the failing tests?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppalaga could you have a look at @gastaldi 's question? Let's see what CI says once it's rebased.
The failures look odd but it might be an infrastructure flake.

bom/application/pom.xml Show resolved Hide resolved
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 21, 2022

@ppalaga could you have a look at @gastaldi 's question?

83688f6:

  • Rebased
  • Added
<dependency>
                <groupId>com.sun.mail</groupId>
                <artifactId>jakarta.mail</artifactId>
                <version>${jakarta.mail.version}</version>
            </dependency>

@gsmet gsmet merged commit 9694bd4 into quarkusio:main Jun 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 23, 2022
@gsmet
Copy link
Member

gsmet commented Jun 23, 2022

Thanks!

@gsmet gsmet modified the milestones: 2.11 - main, 2.10.1.Final Jun 28, 2022
@gsmet
Copy link
Member

gsmet commented Jan 13, 2023

@ppalaga do you think this is still needed for the next 2.7?
@harshmadhani could you check if it's going to be a problem for prod? It might not be as it probably just points to the version we are currently using but let's make sure it doesn't cause you headaches.

@harshmadhani
Copy link
Contributor

@gsmet Yes, since there is no change in versions, it should okay for prod. Thanks !

@ppalaga
Copy link
Contributor Author

ppalaga commented Jan 18, 2023

@ppalaga do you think this is still needed for the next 2.7?

No, in 2.7 we have some workarounds in place that are fine to live with till its EOL

@gsmet
Copy link
Member

gsmet commented Jan 18, 2023

Thanks, let's not backport it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/bugfix
Projects
None yet
5 participants