Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Azure Edge Server rather than MS SQL on Mac M1 #25830

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented May 27, 2022

Partial resolution of #25428. See also discussion in #25648.

To test,

mvn clean 
mvn -Dquickly 
TESTCONTAINERS_RYUK_DISABLED="true" ./mvnw -Dquickly -DskipTests=false -Dstart-containers -f  extensions/reactive-mssql-client/deployment/pom.xml
TESTCONTAINERS_RYUK_DISABLED="true" ./mvnw -Dquickly -DskipTests=false -Dstart-containers -Dtest-containers -f extensions/jdbc/jdbc-mssql
TESTCONTAINERS_RYUK_DISABLED="true" ./mvnw -Dquickly -DskipTests=false -Dstart-containers -Dtest-containers -f integration-tests/jpa-mssql
TESTCONTAINERS_RYUK_DISABLED="true" ./mvnw -Dquickly -DskipTests=false -Dstart-containers -Dtest-containers -f integration-tests/reactive-mssql-client           

The clean and rebuild is needed to avoid issues relating to licence-non-acceptance of the changed image name.

What's changed?

The MS SQL image segfaults on ARM. The best option seemed to be the widely recommended workaround of using Azure Edge Server. The two products are not functionally interchangeable, but there is enough similarity to make it worth running this way.

Note: this change will also affect dev services if built locally, but not in the official releases, unless they are built on M1. I think that’s kind of weird but kind of ok, but I’m open to objections if people think that's too inconsistent.

@quarkus-bot
Copy link

quarkus-bot bot commented May 27, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label May 27, 2022
@holly-cummins holly-cummins changed the title Use Azure Edge Server rather than MS SQL on Mac M1. Use Azure Edge Server rather than MS SQL on Mac M1 May 27, 2022
@holly-cummins holly-cummins marked this pull request as draft May 27, 2022 09:57
@holly-cummins holly-cummins marked this pull request as ready for review May 27, 2022 10:11
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe to me! I can't test it and needs a conflict resolved, so I'll approve already so you can merge it right away when you have a moment to fix it.

@gsmet gsmet force-pushed the holly-mssql-m1-podman-fabric8 branch from 8ab91d6 to 90251aa Compare June 9, 2022 09:56
@gsmet gsmet force-pushed the holly-mssql-m1-podman-fabric8 branch from 90251aa to 4f84d50 Compare June 9, 2022 09:56
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the conflicts, let's merge this.

@gsmet gsmet merged commit 836376c into quarkusio:main Jun 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone Jun 9, 2022
@holly-cummins
Copy link
Contributor Author

Thanks @gsmet, you beat me to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants