-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuteProcessor - more concise format to report incorrect expressions #25810
Conversation
mkouba
commented
May 26, 2022
- resolves Improve errors reporting of QuteProcessor #25724
CC @angelozerr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Ok, let's wait for Angelo's review then ;-) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I cannot test but it looks good to me,because it seems now you have an error per line, and it should be easy to write a pattern to extract information about file name, line number. However, the 2 limitations that I can see are:
|
Hm, didn't try this. Do you really mean "it should not work"? Or "it does not work"? ;-)
I could :D |
@angelozerr Fixed. |
Not tested, it's just a question that I had (corner use case)
Great thanks! |
So we only validate the templates discovered in application archives and extension runtime artifacts. In other words, it should work in a quarkus app. |