-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.9.2 backports 2 #25770
Merged
Merged
2.9.2 backports 2 #25770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a media type with suffix, for example: "application/test+json". Before these changes, Resteasy Reactive was trying to find the writer/reader using only the suffix. For example, with a media type "application/test+json", it would only use "json" to locate the right writer/reader. Spite of this has been working well so far, if users provide a custom writer/reader for a concrete media type with suffix: ```java @Provider @produces("text/test+suffix") public static class SuffixMessageBodyWriter implements ServerMessageBodyWriter<Object> { @OverRide public boolean isWriteable(Class<?> type, Type genericType, ResteasyReactiveResourceInfo target, MediaType mediaType) { // ... } @OverRide public void writeResponse(Object o, Type genericType, ServerRequestContext context) { // ... } // ... } ``` The above writer will never be used. After these changes, we will use the media type with suffix, plus the split parts of the suffix. For example, if the media type with suffix is: "application/test+json", it will try to find the best writer/reader for "application/test+json", "application/test" and then "application/json" (In this order). Fix quarkusio#15982 (cherry picked from commit d6a5178)
Relates to: quarkusio#25744 (cherry picked from commit 2f4decc)
(cherry picked from commit 2e13dcd)
(cherry picked from commit b773d15)
This version uses a maven-compiler-plugin version that is available on Maven Central by default so we are not dependent of JBoss Nexus. (cherry picked from commit 6dceb8b)
Fixes quarkusio#25233 The "encrypt" property is not needed anyway, it is the default of both the JDBC and reactive clients. https://docs.microsoft.com/en-us/sql/connect/jdbc/understanding-ssl-support?view=sql-server-ver15#remarks (cherry picked from commit c4a4640)
(cherry picked from commit a2b1712)
This is simpler than transforming a JDBC url string. (cherry picked from commit 1254a7e)
quarkus-bot
bot
added
area/documentation
area/infra-automation
anything related to CI, bots, etc. that are used to automated our infrastructure
area/reactive-sql-clients
area/rest
area/vertx
labels
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
area/infra
internal and infrastructure related issues
area/infra-automation
anything related to CI, bots, etc. that are used to automated our infrastructure
area/reactive-sql-clients
area/rest
area/vertx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge, I will merge it myself.