Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.2 backports 2 #25770

Merged
merged 8 commits into from
May 25, 2022
Merged

2.9.2 backports 2 #25770

merged 8 commits into from
May 25, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 24, 2022

Please don't merge, I will merge it myself.

Sgitario and others added 8 commits May 24, 2022 23:07
Given a media type with suffix, for example: "application/test+json".

Before these changes, Resteasy Reactive was trying to find the writer/reader using only the suffix. For example, with a media type "application/test+json", it would only use "json" to locate the right writer/reader.

Spite of this has been working well so far, if users provide a custom writer/reader for a concrete media type with suffix:

```java
@Provider
    @produces("text/test+suffix")
    public static class SuffixMessageBodyWriter implements ServerMessageBodyWriter<Object> {

        @OverRide
        public boolean isWriteable(Class<?> type, Type genericType, ResteasyReactiveResourceInfo target, MediaType mediaType) {
           // ...
        }

        @OverRide
        public void writeResponse(Object o, Type genericType, ServerRequestContext context) {
            // ...
        }

        // ...
    }
```

The above writer will never be used.

After these changes, we will use the media type with suffix, plus the split parts of the suffix. For example, if the media type with suffix is: "application/test+json", it will try to find the best writer/reader for "application/test+json", "application/test" and then "application/json" (In this order).

Fix quarkusio#15982

(cherry picked from commit d6a5178)
This version uses a maven-compiler-plugin version that is available on
Maven Central by default so we are not dependent of JBoss Nexus.

(cherry picked from commit 6dceb8b)
Fixes quarkusio#25233

The "encrypt" property is not needed anyway, it is the default of both the JDBC and reactive clients.

https://docs.microsoft.com/en-us/sql/connect/jdbc/understanding-ssl-support?view=sql-server-ver15#remarks
(cherry picked from commit c4a4640)
This is simpler than transforming a JDBC url string.

(cherry picked from commit 1254a7e)
@gsmet gsmet added the area/infra internal and infrastructure related issues label May 24, 2022
@gsmet gsmet self-assigned this May 24, 2022
@quarkus-bot quarkus-bot bot added area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/reactive-sql-clients area/rest area/vertx labels May 24, 2022
@gsmet gsmet merged commit 8b4f62c into quarkusio:2.9 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/infra internal and infrastructure related issues area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/reactive-sql-clients area/rest area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants