Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Quiltflower decompiler support #25729

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 23, 2022

Quiltflower is a new decompiler based on Fernflower
that generates better decompiled code.

This change also deprecates the Fernflower configuration
in favor of the new Quiltflower configuration

@geoand geoand requested a review from gsmet May 23, 2022 14:15
@gsmet
Copy link
Member

gsmet commented May 23, 2022

I saw this one the other day. What I was wondering is if it wasn't better to keep the one maintained by Jetbrains, for which we are sure it's going to be around for a while?
It's an open question, I don't have a strong opinion and Jetbrains might decide to switch to another one themselves.

@geoand
Copy link
Contributor Author

geoand commented May 23, 2022

This seems to be more actively maintained

@geoand
Copy link
Contributor Author

geoand commented May 23, 2022

Moreover, this one has actual Github releases as opposed to Fernflower which only has some hacky support for some of the commits made in the initial repo

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I suppose we will see how it goes, it's an advanced feature anyway.

This doc needs an update: https://quarkus.io/guides/writing-extensions .

@gsmet
Copy link
Member

gsmet commented May 23, 2022

Should have been more precise: search for fernflower in it.

@geoand
Copy link
Contributor Author

geoand commented May 24, 2022

Fair enough. I suppose we will see how it goes, it's an advanced feature anyway.

This doc needs an update: https://quarkus.io/guides/writing-extensions .

done

@geoand geoand requested a review from gsmet May 24, 2022 09:35
Quiltflower is a new decompiler based on Fernflower
that generates better decompiled code.

This change also deprecates the Fernflower configuration
in favor of the new Quiltflower configuration
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's wait for CI.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 24, 2022
@geoand
Copy link
Contributor Author

geoand commented May 24, 2022

💪🏼

@geoand geoand merged commit 7242ed3 into quarkusio:main May 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 24, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 24, 2022
@geoand geoand deleted the quiltflower branch May 24, 2022 14:21
@Asbestosstar
Copy link

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants