Gitpod - add extensions + custom image to get quarkus CLI + contributing.md #25452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
May 9, 2022
jeanphi-baconnais
force-pushed
the
gitpod-complete-config
branch
from
aafc55c to
fd71e2d
Compare
gsmet
requested changes
May 9, 2022
jeanphi-baconnais
force-pushed
the
gitpod-complete-config
branch
from
ea33aad to
308a4a8
Compare
|
Thanks for your review and help @gsmet 🙏 |
gsmet
force-pushed
the
gitpod-complete-config
branch
from
308a4a8 to
8201c4c
Compare
gsmet
approved these changes
May 11, 2022
gsmet
added
the
triage/waiting-for-ci
gsmet
changed the title
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
Would it make sense to add a button in the README (or even in the CONTRIBUTING guide instead) to open in GitPod? [](https://gitpod.io/#https://github.com/quarkusio/quarkus/-/tree/main/)
|
|
Hi @gastaldi, I was hesitant to add this button 😅 Tried to add this one under badges in the README.md file but wasn't sure if this was the right place. And in the contributor file, there is so much information so 🤷♂️ but I could add this one |
maxandersen
reviewed
May 30, 2022
| FROM gitpod/workspace-java-11 | ||
|
|
||
| RUN bash -c ". /home/gitpod/.sdkman/bin/sdkman-init.sh && \ | ||
| sdk install java 11.0.9.j9-adpt && \ |
There was a problem hiding this comment.
why use j9 here and not adoptium which we use everywhere else ?
There was a problem hiding this comment.
oh ! I didn't see that. After reading the project, I didn't find the image to use. Where I can find it please ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Using GitPod, I've just changed few small things :
What do you think about these changes ?