-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register java plugin in Gradle plugins #25128
Conversation
@glefloch should we adjust the templates that are used for project creation as part of this PR? |
I would keep it explicit in the generated project. |
I find this confusing. Why? |
I think this is a fallback to be more resilient to errors. Removing the |
I am not sure there is much value in this PR then. |
I tested it, the order of plugin does not create an issue. This just prevent error when user don't set set the |
It's best practice to apply plugin if you depend on it and react to it with Since plugin application is idempotent order in plugins with this patch wouldn't matter but will avoid confusion.
I had such issue in the past with older Gradle version (somewhere in 6.x) when plugin assumed that |
As discussed on zulip, Quarkus Gradle plugins can't work without the java plugin. A build could fail if plugin are not applied in a correct order. This applies the java plugin by default to make sure no error can happen.
/cc @grossws @gastaldi