Handle client close/cancel on grpc mutiny streaming service #25076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Mutiny GRPC interface for streaming as described here, we eventually see the following error whenever a client closes a connection before the service tries to push down new messages:
What is happening is that the Multi subscription isn't being canceled whenever a client disconnects. Besides the log pollution this behavior can cause some user pain, particulary if the user adds a termination handler to the multi subscription.
If the service pushes messages downstream infrequently we might also see a situation where long disconnected client's subscriptions are still being maintained, possibly causing observability and memory pressure concerns.
The solution here is to simply add a cancel and close handler as the error message suggests. On either on cancel or on close we'll cancel the multi subscription.