Initial Support for SunPKCS11 provider in native image #25068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
gsmet
requested changes
Apr 21, 2022
|
@gsmet I'm doing a minor follow up update to support configuring such providers but it won't work in the native mode, I'll ask Foivos if something can be done (re oracle/graal#2552) |
|
@sberyozkin I'm not sure if we should merge this or if you want us to wait? |
|
@gsmet, Hi, I'd not mind it going into 2.9.0 CR1 if you are OK with it, it won't work in native yet, but there was an earlier query about configuring |
gsmet
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment this PR only registers
SunPKCS11as an additional security provider (which ensures it is available in native image) and starts with a simple integration test. I'm not sure yet if it sufficient to address #21099 as it is hard to automate such tests. In general it is worth starting investing more time intoSunPKCS11, as it can be used for default FIPS configuration as well.