Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary parameter array allocations #25033

Merged
merged 1 commit into from
Apr 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public void restart(RuntimeResource target) {
public void restart(RuntimeResource target, boolean setLocatorTarget) {
this.handlers = target.getHandlerChain();
position = 0;
parameters = new Object[target.getParameterTypes().length];
parameters = target.getParameterTypes().length == 0 ? EMPTY_ARRAY : new Object[target.getParameterTypes().length];
if (setLocatorTarget) {
previousResource = new PreviousResource(this.target, pathParamValues, previousResource);
}
Expand Down Expand Up @@ -646,7 +646,7 @@ protected void requestScopeDeactivated() {

@Override
protected void restarted(boolean keepTarget) {
parameters = new Object[0];
parameters = EMPTY_ARRAY;
if (!keepTarget) {
target = null;
}
Expand Down