Save AtomicBoolean allocation in Arc #25032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to use an atomic boolean in this case, as there aren't any compareAndSwap (or similar) operations, just plain reading and writing of the field, which means a volatile boolean is perfectly fine
mkouba
approved these changes
Apr 20, 2022
mkouba
added
the
triage/waiting-for-ci
stuartwdouglas
approved these changes
Apr 20, 2022
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
Should this be backported? |
|
Yeah, it probably makes sense to backport to 2.7 and 2.8 |
|
I haven't backported it as there are conflicts. I think it can wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to use an
AtomicBooleanin this case,as there aren't any
compareAndSwap(or similar) operations,just plain reading and writing of the field, which means
a
volatile booleanis perfectly fineThis showed up in a sample profiling run I did with async-profiler