Introduce a way to disable integration tests for certain build types #25025
Conversation
| ALL, | ||
| JAR, | ||
| CONTAINER, | ||
| NATIVE_BINARY, |
There was a problem hiding this comment.
Would be nice to have NATIVE_CONTAINER + JAR_CONTAINER as well
There was a problem hiding this comment.
How come? Is there a reason you would want to run tests for jar container and not a native container?
There was a problem hiding this comment.
Maybe. Could think of a configuration/profile that uses an on-heap cache (e.g. caffeine) with an uber-jar, but no cache with a native image (because caches are not sooo great with serial GC in native images from GraalVM community).
There was a problem hiding this comment.
I would rather not do this unless we have a real need for it
|
|
||
| enum ArtifactType { | ||
| ALL, | ||
| JAR, |
There was a problem hiding this comment.
Mind adding javadocs to the corresponding type-strings (like fast-jar, uber-jar, etc)?
There was a problem hiding this comment.
I don't really want to do this, as these strings are internal and not meant to be used by anyone but the testing facility
There was a problem hiding this comment.
Meant the values for quarkus.package.type
There was a problem hiding this comment.
That information isn't available at this point and in any case, for tests it should not make a difference - I mean in what scenario would want to only not execute a test if it's for an uber-jar for example?
There was a problem hiding this comment.
Thought it could be useful information for users to associate quarkus.package.type=fast-jar with the JAR enum value.
Good point, added a second commit |
...framework/junit5/src/main/java/io/quarkus/test/junit/DisabledOnIntegrationTestCondition.java
Outdated
Show resolved
Hide resolved
This probably should have been done when we deprecated @NativeImageTest
Relates to: #25010