Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed registry platforms config merging #25006

Merged

Conversation

aloubyansky
Copy link
Member

I found this testing quarkusio/registry.quarkus.io#92

@aloubyansky aloubyansky requested a review from gastaldi April 19, 2022 14:47
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Apr 19, 2022
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small Nitpick: you may want to use immutable RegistryConfigs in the test

@aloubyansky aloubyansky merged commit de9f7b1 into quarkusio:main Apr 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 19, 2022
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.2.Final Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants