Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle DevServices: limit CPU to 2 to avoid excessive memory consumption #24975

Closed
wants to merge 1 commit into from

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Apr 16, 2022

(removed)

@Sanne Sanne force-pushed the OracleDevImprovements branch from 7f2e295 to a7995ae Compare April 16, 2022 13:59
@Sanne
Copy link
Member Author

Sanne commented Apr 16, 2022

@DavideD we might want to apply similar tuning in Hibernate Reactive ?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@Felk
Copy link
Contributor

Felk commented Apr 19, 2022

I wanna try if this works, but I am really having trouble getting quarkus built and the snapshot pushed to our company internal repository. Is there a way to have the CI build and publish a version of this?

@geoand
Copy link
Contributor

geoand commented Apr 19, 2022

Unfortunately, no, we don't publish snapshots of pull requests

@geoand
Copy link
Contributor

geoand commented Apr 19, 2022

Have you read the contributing guide to see how to build ?

@Felk
Copy link
Contributor

Felk commented Apr 19, 2022

Yes, and I can get it to build with the quickly profile, given I don't touch the version to be anything else than 999-SNAPSHOT. I'm just struggling to mvn deploy it to our jfrog artifactory (it needs to be there because the fat machine with > 100 cores is our gitlab runner host, not anyone's local machine).

I changed the distributionManagement in several places to point to our company artifactory:

<distributionManagement>
	<repository>
		<id>acme-releases</id>
		<name>ACME Release</name>
		<url>https://artifactory.acme.net/artifactory/acme-releases</url>
	</repository>
	<snapshotRepository>
		<id>acme-snapshots</id>
		<name>ACME Snapshots</name>
		<url>https://artifactory.acme.net/artifactory/acme-snapshots</url>
		<uniqueVersion>false</uniqueVersion>
	</snapshotRepository>
</distributionManagement>

but I can't push the snapshots there:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project quarkus-ide-config: Failed to deploy artifacts: Could not transfer artifact io.quarkus:quarkus-ide-config:jar:999-20220419.135547-1 from/to acme-snapshots (https://artifactory.acme.net/artifactory/acme-snapshots): authorization failed for https://artifactory.acme.net/artifactory/acme-snapshots/io/quarkus/quarkus-ide-config/999-SNAPSHOT/quarkus-ide-config-999-20220419.135547-1.jar, status: 403 Forbidden -> [Help 1]

It's most certainly a wetware issue and has nothing to do with quarkus. For me in 99% of cases a 403 Forbidden error is not actually permission related (I can push to that repository fine in other cases), but instead indicated me trying to push the wrong thing to the wrong repository. I just don't see what is wrong there. Maven sometimes just breaks my head. I'll try again tomorrow if I find the time.

@Sanne
Copy link
Member Author

Sanne commented Apr 19, 2022

@Felk I can try verifying that my patch does indeed translate to the equivalent of running docker run --cpus=2 .

Perhaps you could verify on your 100 CPU machine if running oracle that way works fine?

Then we can assume this is most likely fixed and merge it since it seems otherwise harmless. You can then more easily test it at the next release, and in worse case we can re-open the issue.

@Sanne
Copy link
Member Author

Sanne commented Apr 19, 2022

So apparently I actually need to use withNanoCPUs(2_000_000_000l) for this to be effective. Need to update the PR.

@Sanne
Copy link
Member Author

Sanne commented Apr 19, 2022

Something is off with github, it's not reflecting the changes I just pushed. Will need to open a new PR.

Replaced by #25009

@Sanne Sanne closed this Apr 19, 2022
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants