Use gradlew in native image docs #24969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
glefloch
reviewed
Apr 15, 2022
build-parent/pom.xml
Outdated
| @@ -39,7 +39,7 @@ | |||
| <!-- These properties are needed in order for them to be resolvable by the documentation --> | |||
| <!-- The Graal version we suggest using in documentation - as that's | |||
| what we work with by self downloading it: --> | |||
| <graal-sdk.version-for-documentation>22.0.0.2</graal-sdk.version-for-documentation> | |||
| <graal-sdk.version-for-documentation>22.0</graal-sdk.version-for-documentation> | |||
There was a problem hiding this comment.
Is that change necessary for documentation update?
| @@ -566,6 +566,8 @@ Sample Dockerfile for building with Gradle: | |||
| ---- | |||
| ## Stage 1 : build with maven builder image with native capabilities | |||
| FROM quay.io/quarkus/ubi-quarkus-native-image:{graalvm-flavor} AS build | |||
| USER root | |||
| RUN microdnf install findutils | |||
There was a problem hiding this comment.
is find utils necessary for building the native artifact?
There was a problem hiding this comment.
gradlew ( https://github.com/gradle/gradle/blob/master/gradlew , line 235 ) uses xargs which are not in the image by default.
docs/pom.xml
Outdated
| @@ -2786,7 +2786,7 @@ | |||
| <quarkus-version>${project.version}</quarkus-version> | |||
| <surefire-version>${version.surefire.plugin}</surefire-version> | |||
| <graalvm-version>${graal-sdk.version-for-documentation}</graalvm-version> | |||
| <graalvm-flavor>${graal-sdk.version-for-documentation}-java11</graalvm-flavor> | |||
| <graalvm-flavor>${graal-sdk.version-for-documentation}-java17</graalvm-flavor> | |||
There was a problem hiding this comment.
I know if we want to set all documentation reference to java 17 as quarkus is still based on Java 11
|
Just a note that we'll need to have the commits squashed once everything else is addressed |
glefloch
reviewed
Apr 19, 2022
klemen-df
force-pushed
the
instructions-update
branch
from
3f5dc9e to
4785d6c
Compare
|
Done. |
glefloch
reviewed
Apr 20, 2022
klemen-df
force-pushed
the
instructions-update
branch
from
5c87147 to
9486032
Compare
glefloch
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version, updated sinstructions