Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta migration: Agroal, Hibernate ORM, Hibernate Search... #24879

Merged
merged 8 commits into from
Apr 12, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 11, 2022

For now, I build a fork of Agroal locally while waiting for the release.

@quarkus-bot quarkus-bot bot added area/agroal area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/jakarta area/metrics area/narayana Transactions / Narayana area/panache area/persistence OBSOLETE, DO NOT USE area/smallrye labels Apr 11, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 11, 2022

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 11, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member Author

gsmet commented Apr 12, 2022

@glefloch any chance you could have a look at the Gradle failure? I have no idea how what I did could have triggered the issue and the setup of the test is a bit complex.

@gsmet
Copy link
Member Author

gsmet commented Apr 12, 2022

BTW, I can reproduce it locally so there's a real issue. But no idea why the dependency is now popping up.

From what I can see this particular build brings implementation("io.quarkus:quarkus-agroal-deployment") from ext-a so its not surprising that Agroal is around in the deployment dir but maybe I'm missing something.

@glefloch
Copy link
Member

glefloch commented Apr 12, 2022

@gsmet yes I will have a look this afternoon.

@gsmet
Copy link
Member Author

gsmet commented Apr 12, 2022

@glefloch cool, thanks!

@Sanne
Copy link
Member

Sanne commented Apr 12, 2022 via email

@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Apr 12, 2022
@glefloch
Copy link
Member

Looking at git blame it seems that narayana-deployment and agraoal-deployment dependencies where added by mistake when testing the validation task of io.quarkus.extension Gradle plugin.

In that test we check that agroal is not transitively imported when depending on panache-reactive (we add an issue on hat), however, I don't understand why it only starts failing now ... I pushed a fix that remove those dependencies.

@gsmet
Copy link
Member Author

gsmet commented Apr 12, 2022

thanks @glefloch

@gsmet gsmet merged commit 56879dd into quarkusio:main Apr 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants