Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to wiremock-jre8-standalone which is more Jakarta friendly #24803

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 6, 2022

Also upgrade Wiremock to 2.32.0 while on it.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/rest area/security area/spring Issues relating to the Spring integration area/testing labels Apr 6, 2022
@famod
Copy link
Member

famod commented Apr 6, 2022

Hum, why wasn't it updated, given we have com.github.tomakehurst:wiremock-jre8 in dependabot.yml?
Anyway, should probably be changed to wiremock-jre8-standalone there too.

@gsmet
Copy link
Member Author

gsmet commented Apr 6, 2022

ah I thought it was not there because it wasn't updated but the problem is this line:
https://github.com/quarkusio/quarkus/blob/main/build-parent/pom.xml#L751

I will add a wildcard.

Also upgrade Wiremock to 2.32.0 while at it.
@gsmet gsmet force-pushed the wiremock-standalone branch from e141e8a to 3627b61 Compare April 6, 2022 19:21
@gsmet gsmet marked this pull request as ready for review April 6, 2022 19:21
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Apr 6, 2022
@gsmet
Copy link
Member Author

gsmet commented Apr 6, 2022

@famod yeah so wiremock had not been updated for a long time (it has been replaced by the jre8 version) so that's why things weren't updated anyway: we use the latest common version (+ the fact that wiremock wasn't in the Dependabot config anyway).

The good thing is that the new versions of the Maven plugin allows you to choose your Wiremock artifact so I made everything consistent.

@gsmet gsmet merged commit 8b379af into quarkusio:main Apr 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jakarta area/rest area/security area/spring Issues relating to the Spring integration area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants