Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute CDI integration - fix named dependent beans #24792

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 6, 2022

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/qute The template engine labels Apr 6, 2022
@mkouba mkouba requested review from gastaldi and manovotn April 6, 2022 11:27
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've added some comments.

- dependent beans are now: 1) shared across all expressions for a single rendering operation, 2) destroyed correctly after
the rendering finished
- resolves quarkusio#24137
@mkouba mkouba requested a review from manovotn April 7, 2022 09:05
@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 7, 2022
@mkouba mkouba merged commit f34989e into quarkusio:main Apr 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 7, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/qute The template engine kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute CDI integration - named dependent bean is destroyed before it's actually used
3 participants