Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IT main for GraalVM >= 22.1 #24767

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Apr 5, 2022

oracle/graal#4222 introduces some changes in the way that reflection metadata are added to native image resulting in some additional metadata landing in the native image with GraalVM 22.1, that were previously not included.

This PR makes Quarkus' integration test main to accept this new behavior.

@quarkus-bot

This comment has been minimized.

@zakkak zakkak force-pushed the fix-it-main-22.1 branch from bbc9e3a to 4d0ce00 Compare April 5, 2022 13:15
@quarkus-bot

This comment has been minimized.

@zakkak zakkak force-pushed the fix-it-main-22.1 branch from 4d0ce00 to 972763d Compare April 5, 2022 14:47
@zakkak zakkak requested a review from geoand April 6, 2022 12:05
@zakkak zakkak force-pushed the fix-it-main-22.1 branch from 972763d to 8c91fee Compare April 7, 2022 07:16
@zakkak zakkak requested a review from geoand April 7, 2022 07:18
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 7, 2022
@quarkus-bot

This comment has been minimized.

@zakkak zakkak force-pushed the fix-it-main-22.1 branch from 8c91fee to bc90454 Compare April 7, 2022 08:47
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 7, 2022

Failing Jobs - Building bc90454

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance 

📦 tcks/microprofile-fault-tolerance

org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@zakkak
Copy link
Contributor Author

zakkak commented Apr 8, 2022

The CI failure seems unrelated.

@geoand geoand merged commit b2700d0 into quarkusio:main Apr 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 8, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 8, 2022
@zakkak zakkak deleted the fix-it-main-22.1 branch April 8, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants