Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lazy task api in gradle plugins #24748

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

grossws
Copy link
Contributor

@grossws grossws commented Apr 5, 2022

Minor modifications to avoid eager task creating when they aren't required for build.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Apr 5, 2022
@grossws
Copy link
Contributor Author

grossws commented Apr 5, 2022

@glefloch, I guess you're the best person to ping about Gradle improvements. If you have a bit of time to chat about that I sent a message to #dev on Zulip.

@geoand geoand requested a review from glefloch April 5, 2022 06:59
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @grossws

@quarkus-bot

This comment has been minimized.

@grossws
Copy link
Contributor Author

grossws commented Apr 5, 2022

Heh, now I need to import full project in the IDE. Where do I get maven:rewrite-maven-plugin:4.21.0-SNAPSHOT?

@glefloch
Copy link
Member

glefloch commented Apr 5, 2022

I would say in maven central, I haven't any custom repository configuration on my machine, and I never had issue with maven plugins.
There is a ˋCONTRIBUTION.md` in the root directory of the project with instructions for importing the project in IDE. That may help you

@grossws
Copy link
Contributor Author

grossws commented Apr 5, 2022

Yeah, I read that, of course. It just takes a while for IDEA to import project and download jars/sources.
Central doesn't host snapshot versions, so you likely have it in maven local repo. I just built it from source (after rewinding to some old commit).
Unfortunately IDE doesn't see that quarkus-gradle-model depends gradle api so I'm running required integration tests directly with maven. I'll update PR later. I'd need to run gradle under integration tests with debug and hook there. At least I now can trace where it fails.

@gsmet
Copy link
Member

gsmet commented Apr 6, 2022

@grossws you can ignore the rewrite maven plugin, it's not used in a standard build

@grossws
Copy link
Contributor Author

grossws commented Apr 6, 2022

@gsmet, thanks for the info

@grossws grossws force-pushed the gradle-lazy-task-api branch 2 times, most recently from 6d08e73 to b4b915c Compare April 24, 2022 12:23
@grossws
Copy link
Contributor Author

grossws commented Apr 24, 2022

@glefloch, I've updated this PR too to fix issue found by integration tests and reworded commit names according to style preferred here.

Gradle integation tests pass on my laptop. Could you respin CI for it, please.

@quarkus-bot

This comment has been minimized.

@grossws grossws force-pushed the gradle-lazy-task-api branch from b4b915c to c572b97 Compare April 24, 2022 15:26
@Sanne Sanne requested a review from glefloch June 22, 2022 10:37
@Sanne
Copy link
Member

Sanne commented Jun 22, 2022

@grossws - sorry it took so long, could you rebase it and resolve the conflicts please?

@glefloch
Copy link
Member

@grossws sorry that delay could you rebase your branch and squash your commits? Otherwise Everything looks good to me.

@grossws
Copy link
Contributor Author

grossws commented Jun 27, 2022

@glefloch, I'll try to update the PR later this week or on a weekend

@grossws grossws force-pushed the gradle-lazy-task-api branch 2 times, most recently from 2a0d0e2 to fc43c9b Compare July 9, 2022 15:34
@grossws
Copy link
Contributor Author

grossws commented Jul 9, 2022

@Sanne, @glefloch, I've rebased, updated a bit & squashed commits into one.

It seemed to me that you (as in Quarkus committers) aren't against plugin API changes between minor version updates. If it's the case I'd like to push some more changes to improve Gradle plugins.

@glefloch
Copy link
Member

glefloch commented Jul 9, 2022

Thanks @grossws i will have a look. Regarding API changes, we avoid breaking backward compatibility but feel free to open new PRs. :)

@gsmet
Copy link
Member

gsmet commented Jul 19, 2022

@glefloch could you have a look at this one before we ask for a rebase?

Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry for the delay

@grossws grossws force-pushed the gradle-lazy-task-api branch from fc43c9b to db44d03 Compare July 27, 2022 13:16
@grossws grossws force-pushed the gradle-lazy-task-api branch from db44d03 to 7fbb2f3 Compare July 27, 2022 13:17
@grossws
Copy link
Contributor Author

grossws commented Jul 27, 2022

@glefloch, @gsmet, rebased onto current main

@quarkus-bot

This comment has been minimized.

@glefloch glefloch merged commit 134f385 into quarkusio:main Jul 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 27, 2022
@glefloch
Copy link
Member

Thanks @grossws

@grossws grossws deleted the gradle-lazy-task-api branch July 28, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants