-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lazy task api in gradle plugins #24748
Conversation
@glefloch, I guess you're the best person to ping about Gradle improvements. If you have a bit of time to chat about that I sent a message to #dev on Zulip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @grossws
This comment has been minimized.
This comment has been minimized.
Heh, now I need to import full project in the IDE. Where do I get |
I would say in maven central, I haven't any custom repository configuration on my machine, and I never had issue with maven plugins. |
Yeah, I read that, of course. It just takes a while for IDEA to import project and download jars/sources. |
@grossws you can ignore the rewrite maven plugin, it's not used in a standard build |
@gsmet, thanks for the info |
6d08e73
to
b4b915c
Compare
@glefloch, I've updated this PR too to fix issue found by integration tests and reworded commit names according to style preferred here. Gradle integation tests pass on my laptop. Could you respin CI for it, please. |
This comment has been minimized.
This comment has been minimized.
b4b915c
to
c572b97
Compare
@grossws - sorry it took so long, could you rebase it and resolve the conflicts please? |
@grossws sorry that delay could you rebase your branch and squash your commits? Otherwise Everything looks good to me. |
@glefloch, I'll try to update the PR later this week or on a weekend |
2a0d0e2
to
fc43c9b
Compare
Thanks @grossws i will have a look. Regarding API changes, we avoid breaking backward compatibility but feel free to open new PRs. :) |
@glefloch could you have a look at this one before we ask for a rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Sorry for the delay
fc43c9b
to
db44d03
Compare
Signed-off-by: Konstantin Gribov <[email protected]>
db44d03
to
7fbb2f3
Compare
This comment has been minimized.
This comment has been minimized.
Thanks @grossws |
Minor modifications to avoid eager task creating when they aren't required for build.