Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Keycloak DevService if quarkus.oidc.provider is set #24699

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Skip Keycloak DevService if quarkus.oidc.provider is set #24699

merged 1 commit into from
Apr 1, 2022

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Apr 1, 2022 •
edited
Loading

quarkus.oidc.provider composes several properties, for example, quarkus.oidc.provider=google configures OidcTenantConfig with quarkus.auth-server-url and 2 more properties in OidcRecorder. Keycloak DevService thinks quarkus.auth-server-url is not set and launches a container. This PR updates KeycloakDevServicesProcessor to check quarkus.oidc.provider and skip further processing if it is set

@quarkus-bot quarkus-bot bot added the area/oidc label Apr 1, 2022
@sberyozkin sberyozkin requested a review from geoand April 1, 2022 17:52
geoand
geoand approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@sberyozkin
Copy link
Member Author

Thanks @geoand

@sberyozkin sberyozkin merged commit 9aab340 into quarkusio:main Apr 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 1, 2022
@sberyozkin sberyozkin deleted the skip_devservices_keycloak_if_provider_configured branch April 1, 2022 18:41
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.1.Final Apr 11, 2022
@gsmet gsmet modified the milestones: 2.8.1.Final, 2.7.6.Final May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/oidc
Projects
None yet
Milestone
2.7.6.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@sberyozkin @geoand @gsmet