Fix expired certificates #24688
Fix expired certificates #24688
Conversation
This comment has been minimized.
This comment has been minimized.
geoand
force-pushed
the
expired-certificates
branch
from
7a2f8c8 to
7eaaaad
Compare
This comment has been minimized.
This comment has been minimized.
|
@cescoffier @sberyozkin didn't you guys have something to generate a certificate at build time somewhere? |
|
During Quarkus build time? That would be very weird. During a maven phase, I don't have anything but that could be useful. |
|
Yeah I was thinking of Maven. I thought we had something. |
|
@geoand do you mind just disabling the tests and we will let @michalszynkiewicz deal with it? |
|
hmm... at least some of these tests use badssl.com which seems to be down |
|
I'm not the author of the tests but will try to replace badssl.com with something that is set up during the tests |
|
Actually it is not resolvable, not down. |
|
chromium/badssl.com#500 - someone is apparently working on it |
|
@geoand maybe we could reopen this PR retry it when the DNS for badssl is resolved? |
|
Sure yeah |
This comment has been minimized.
This comment has been minimized.
|
Our tests shouldn't depend on an external service that we don't manage. |
geoand
force-pushed
the
expired-certificates
branch
from
7eaaaad to
3bc0856
Compare
|
Oh, those are still disabled?
|
…tificates" This reverts commit c671254.
geoand
force-pushed
the
expired-certificates
branch
from
3bc0856 to
552b585
Compare
|
CI is passing, should we get this in? |
|
Merged. If the new certificates can expire again, we should probably document how to generate them. |
|
Yes, indeed |
|
Adding the instructions in the description of the PR is enough IMHO. We will find them easily. |
|
Done :) |
This was done by running:
integration-tests/rest-client/generate-trust-store-for-bad-ssl.sh