Fix autodetection of Java version for project creation using CLI #24645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make sure project created with Java 18 will use Java 17 and not Java 11. Finally, use autodetection for QuarkusJBangCodestartProjectInputBuilder too. Fixes quarkusio#24613
quarkus-bot
bot
added
area/cli
gsmet
commented
Mar 30, 2022
Comment on lines
-25
to
+26
| "--java" }, description = "Target Java version.\n Valid values: ${COMPLETION-CANDIDATES}", completionCandidates = VersionCandidates.class, defaultValue = CreateProjectHelper.DEFAULT_JAVA_VERSION) | ||
| String javaVersion = CreateProjectHelper.DEFAULT_JAVA_VERSION; | ||
| "--java" }, description = "Target Java version.\n Valid values: ${COMPLETION-CANDIDATES}", completionCandidates = VersionCandidates.class, defaultValue = CreateProjectHelper.DETECT_JAVA_RUNTIME_VERSION) | ||
| String javaVersion = CreateProjectHelper.DETECT_JAVA_RUNTIME_VERSION; |
There was a problem hiding this comment.
The core of the issue is here. The rest is improvements on top of what we were doing, mostly to consider that the best version for 18 is 17, not 11.
ebullient
approved these changes
Mar 30, 2022
Comment on lines
-25
to
+26
| "--java" }, description = "Target Java version.\n Valid values: ${COMPLETION-CANDIDATES}", completionCandidates = VersionCandidates.class, defaultValue = CreateProjectHelper.DEFAULT_JAVA_VERSION) | ||
| String javaVersion = CreateProjectHelper.DEFAULT_JAVA_VERSION; | ||
| "--java" }, description = "Target Java version.\n Valid values: ${COMPLETION-CANDIDATES}", completionCandidates = VersionCandidates.class, defaultValue = CreateProjectHelper.DETECT_JAVA_RUNTIME_VERSION) | ||
| String javaVersion = CreateProjectHelper.DETECT_JAVA_RUNTIME_VERSION; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make sure project created with Java 18 will use Java 17 and not
Java 11.
Finally, use autodetection for QuarkusJBangCodestartProjectInputBuilder
too.
Fixes #24613