Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't record start time when Reactive REST Client returns a Multi #24608

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 29, 2022

Fixes: #23829

P.S. Opening as a draft as I created this totally blindly, as I don't really know how to test it

@michalszynkiewicz
Copy link
Member

michalszynkiewicz commented Mar 30, 2022

this won't work for blocking read of SSE things, would it?
Even if so, it's a good start, I think

@geoand
Copy link
Contributor Author

geoand commented Mar 30, 2022

Indeed it won't. But what does a client method that does blocking read of SSE look like?

@michalszynkiewicz
Copy link
Member

Indeed it won't. But what does a client method that does blocking read of SSE look like?

I'm guessing we are blocking a thread and returning the result as a list at the end. I never tried though so not sure if it works:)

@geoand geoand marked this pull request as ready for review March 30, 2022 11:40
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 30, 2022
@geoand geoand merged commit 0de2c19 into quarkusio:main Mar 30, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Mar 30, 2022
@geoand geoand deleted the #23829 branch March 30, 2022 14:30
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST Client Reactive: skip measuring time for SSE calls
2 participants