Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the test extension out of the core module #24574

Merged
merged 3 commits into from
Mar 26, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 26, 2022

This has been bugging me since the beginning and is in the way for the
Jakarta migration so let's move this one to the ITs as it's where it should have been from day 1.

In passing, made DeploymentDependencyRuleSupport work with directories as it's needed in this case and rename an IT module that was misnamed.

@gsmet gsmet requested a review from gastaldi March 26, 2022 14:10
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@quarkus-bot

This comment has been minimized.

gsmet added 2 commits March 26, 2022 15:28
This has been bugging me since the beginning and is in the way for the
Jakarta migration.
@gsmet gsmet force-pushed the move-test-extension branch from 5709e1b to ad20601 Compare March 26, 2022 14:33
@gsmet
Copy link
Member Author

gsmet commented Mar 26, 2022

Looks like the build items of this extension were included in the generated documentation whereas they shouldn't have been. I fixed it.

@gsmet gsmet merged commit 7399136 into quarkusio:main Mar 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants