Allow reflective access to Jaeger DTO classes' fields #24491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jaeger client uses GSON to unmarshall JSON messages containing sampling configuration to Java objects. GSON uses reflection on the DTO object to determine fields that match the properties in the JSON object. by default, the ReflectiveClassBuildItem does not allow access to a class' fields via reflection. This PR therefore explicitly enables it. This should (finally) fix quarkusio#10402 Signed-off-by: Kai Hudalla <[email protected]>
gsmet
approved these changes
Mar 23, 2022
|
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items.
|
|
Thanks! |
sophokles73
added a commit
to eclipse-hono/hono
that referenced
this pull request
Mar 25, 2022
See quarkusio/quarkus#24491 Signed-off-by: Kai Hudalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jaeger client uses GSON to unmarshall JSON messages containing
sampling configuration to Java objects. GSON uses reflection on the DTO
object to determine fields that match the properties in the JSON object.
By default, the ReflectiveClassBuildItem does not allow access to a
class' fields via reflection so the error described in #10402 still occurs.
This PR explicitly enables it and should thus (finally) fix #10402.