Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler - scheduled methods are not inherited #24270

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 11, 2022

  • this is a breaking change
  • however, the current behavior is undocumented and inconsistent; e.g.
    if Scheduled#identity() is used then the build always fails
  • also the scope annotation is not added automatically to a subclass of a class that
    declares a Scheduled annotation, i.e. the class would be ignored and would
    result in runtime error
  • resolves @Scheduled method invoked both on original bean and @Alternative bean #24212

@mkouba mkouba added this to the 2.8 - main milestone Mar 11, 2022
@mkouba mkouba requested a review from machi1990 March 11, 2022 12:27
@mkouba
Copy link
Contributor Author

mkouba commented Mar 11, 2022

I'm going to update the migration guide once this PR is merged..

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 11, 2022
- this is a breaking change
- however, the current behavior is undocumented and inconsistent; e.g.
if Scheduled#identity() is used then the build always fails
- also the scope annotation is not added automatically to a subclass of a class that
declares a Scheduled annotation, i.e. the class would be ignored and would
result in runtime error
- resolves quarkusio#24212
@mkouba
Copy link
Contributor Author

mkouba commented Mar 11, 2022

I'm going to update the migration guide once this PR is merged..

Done: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.8#scheduler

@machi1990
Copy link
Member

I'm going to update the migration guide once this PR is merged..

Done: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.8#scheduler

Thanks

@mkouba mkouba merged commit d996c2a into quarkusio:main Mar 11, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Scheduled method invoked both on original bean and @Alternative bean
2 participants