-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect container runtime when using Jib #24238
Conversation
The detection uses the same method Quarkus already used when building the native binary using a container build Fixes: quarkusio#24231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if we should backport it given the current behavior is not aligned with other parts of the code?
I am not sure... All the code changes are internal, but there is a slight chance some extension could depend on the Util and break.... I would say let's not backport for now but if this is requested, I can do a |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building a6745e0
Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ |
I'll need to check the failure, it might be related |
The failure does not seem related actually, but I'll restart CI just to be on the safe side |
Let's keep this in mind for the next |
I made a specific backport with backwards compatibility here: #24291 . |
The detection uses the same method Quarkus already
used when building the native binary using a container build
Fixes: #24231