Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect container runtime when using Jib #24238

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 10, 2022

The detection uses the same method Quarkus already
used when building the native binary using a container build

Fixes: #24231

The detection uses the same method Quarkus already
used when building the native binary using a container build

Fixes: quarkusio#24231
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we should backport it given the current behavior is not aligned with other parts of the code?

@geoand
Copy link
Contributor Author

geoand commented Mar 10, 2022

I am not sure... All the code changes are internal, but there is a slight chance some extension could depend on the Util and break....

I would say let's not backport for now but if this is requested, I can do a 2.7 specific change that just copies the detection code.

@geoand geoand changed the title Detect container runtime in when using Jib Detect container runtime when using Jib Mar 10, 2022
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 10, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 10, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a6745e0

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/container-image/maven-invoker-way 

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

@geoand
Copy link
Contributor Author

geoand commented Mar 10, 2022

I'll need to check the failure, it might be related

@geoand
Copy link
Contributor Author

geoand commented Mar 10, 2022

The failure does not seem related actually, but I'll restart CI just to be on the safe side

@geoand geoand merged commit 6d5abf7 into quarkusio:main Mar 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 11, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 11, 2022
@geoand geoand deleted the #24231 branch March 11, 2022 03:53
@jesperpedersen
Copy link

@gsmet @geoand A backport - in some form - to 2.7 would help the Quarkus Operator SDK in its native builds, so it would be greatly appreciated
@metacosm FYI

@geoand
Copy link
Contributor Author

geoand commented Mar 11, 2022

Let's keep this in mind for the next 2.7 release.

@gsmet
Copy link
Member

gsmet commented Mar 14, 2022

I made a specific backport with backwards compatibility here: #24291 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus/jib: Native build fails if docker isn't installed
3 participants