-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce --link-at-build-time flag for GraalVM 22.1 and later #24213
Conversation
oracle/graal#4305 makes `--allow-incomplete-classpath` the default behavior (removing the flag) and introduces a new flag `--link-at-build-time` which enables us to set which classes/packages we require to be resolvable at build time. Passing `--link-at-build-time` without arguments to `native-image` requires all classes/packages to be resolvable at build time, essentially bringing the pre-22.1 behavior back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No please don't enable it "blanket": it will break some extensions, such as the oracle JDBC driver.
The global enablement flag needs to take into account exceptions; I suspect a new build item needs to be introduced to control the flag explicitly on each jar.
It is not enabled "blanket", it is disabled if any
That would be an optimization. This PR aims to reproduce the current behavior with 22.1 and later while also avoiding getting warnings. |
oh, missed that! sorry - my mind is elsewhere as I'm actually on PTO but this PR got my attention :) Many thanks @zakkak :) |
Thx for the quick turnaround on this @zakkak |
oracle/graal#4305 makes
--allow-incomplete-classpath
the default behavior (removing the flag) and introduces a new flag--link-at-build-time
which enables us to set which classes/packages we require to be resolvable at build time. Passing--link-at-build-time
without arguments tonative-image
requires all classes/packages to be resolvable at build time, essentially bringing the pre-22.1 behavior back.