Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Resteasy Reactive, fix line separator for "x-ndjson" and "stream+json". #24200

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Mar 9, 2022

We're wrongly using /n instead of \n.
This was done in #20908

We're wrongly using `/n` instead of `\n`.
This was done in quarkusio#20908
@Sgitario
Copy link
Contributor Author

Sgitario commented Mar 9, 2022

cc @michalszynkiewicz

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 9, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/rest label Mar 9, 2022
@Sgitario Sgitario changed the title Resteasy Reactive: Fix line separator for "x-ndjson" and "stream+json". In Resteasy Reactive: Fix line separator for "x-ndjson" and "stream+json". Mar 9, 2022
@Sgitario Sgitario changed the title In Resteasy Reactive: Fix line separator for "x-ndjson" and "stream+json". In Resteasy Reactive, fix line separator for "x-ndjson" and "stream+json". Mar 9, 2022
@geoand
Copy link
Contributor

geoand commented Mar 9, 2022

Ouch... nice catch

@michalszynkiewicz
Copy link
Member

michalszynkiewicz commented Mar 9, 2022

Ouch... nice catch

found it when adding support for ndjson in the client

@gsmet
Copy link
Member

gsmet commented Mar 9, 2022

Well, I think it was high time to invent a brand new new line separator besides \r, \n and \r\n. Are we going to innovate or not?!?

@geoand
Copy link
Contributor

geoand commented Mar 9, 2022

😆

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 9, 2022

Failing Jobs - Building a619566

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance 

📦 tcks/microprofile-fault-tolerance

org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@gsmet gsmet merged commit 1bc87cc into quarkusio:main Mar 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 9, 2022
@Sgitario Sgitario deleted the fix_line_separator_sse branch March 9, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants