Consistent Span name and http.route.name #24017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radcortez it looks like a bugfix? |
ebullient
requested changes
Feb 28, 2022
...ry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/tracing/TracerProcessor.java
Show resolved
Hide resolved
Sort of. Historically, our initial implementation omitted the leading slash from the Span name, which I kept until the OTel API fixed an issue in how to set the For reference: open-telemetry/opentelemetry-java-instrumentation#4716 |
ebullient
approved these changes
Mar 1, 2022
rsvoboda
added a commit
to rsvoboda/beefy-scenarios
that referenced
this pull request
Mar 1, 2022
Sor of breaking change introduced in quarkusio/quarkus#24017
|
Ecosystem CI failed on https://github.com/quarkus-qe/beefy-scenarios repo because of this. I see this change as breaking change as people can be relying on the behavior when Quarkus omitted the leading slash from the Span name. @radcortez please add entry into https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.8 |
|
Sure. Thanks! |
7 tasks
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Jun 11, 2022
Expected operation name is prefixed with forward slash is now as span name creation strategy has [recently changed](quarkusio/quarkus#24017)
8 tasks
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Jun 13, 2022
Expected operation name is prefixed with forward slash is now as span name creation strategy has [recently changed](quarkusio/quarkus#24017)
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Jun 13, 2022
Expected operation name is prefixed with forward slash is now as span name creation strategy has [recently changed](quarkusio/quarkus#24017)
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Jun 13, 2022
Expected operation name is prefixed with forward slash is now as span name creation strategy has [recently changed](quarkusio/quarkus#24017)
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Jun 13, 2022
Expected operation name is prefixed with forward slash is now as span name creation strategy has [recently changed](quarkusio/quarkus#24017)
pjgg
pushed a commit
to pjgg/quarkus-test-suite
that referenced
this pull request
Jun 14, 2022
Expected operation name is prefixed with forward slash is now as span name creation strategy has [recently changed](quarkusio/quarkus#24017) (cherry picked from commit 4564b78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.