Deprecate the quarkus-resteasy-mutiny extension #24005
Merged
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Feb 28, 2022
gastaldi
reviewed
Feb 28, 2022
.../deployment/src/main/java/io/quarkus/resteasy/mutiny/deployment/ResteasyMutinyProcessor.java
Outdated
Show resolved
Hide resolved
|
I wonder if we should sneak this one in into 2.7? Maybe worth asking @tqvarnst . |
Sanne
approved these changes
Feb 28, 2022
Sanne
added
the
triage/waiting-for-ci
gsmet
force-pushed
the
deprecate-resteasy-classic-mutiny
branch
from
08553f5 to
212f0dc
Compare
gastaldi
approved these changes
Feb 28, 2022
gastaldi
reviewed
Feb 28, 2022
| return new FeatureBuildItem(Feature.RESTEASY_MUTINY); | ||
| } | ||
|
|
||
| void warn() { | ||
| Logger.getLogger(ResteasyMutinyProcessor.class).warn("The quarkus-resteasy-mutiny extension is deprecated. " + |
There was a problem hiding this comment.
Maybe it's easier to use io.quarkus.logging.Log.warn here, but this is fine
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
@gsmet / @cescoffier there should be a section about this in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.8 imho the message from the warning can be used, it's quite nice: |
|
Good point, added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a warning explaining why it's deprecated.