Ensure that remote-dev works with containers created by Jib #24004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue without this is that Jib overwrites the owner of the working directory and sets it to root. With this fix, we add a faux layer that simply reverts the owner back to the default when the default base image is used. Originally discussed at: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/remote.20dev.20in.202.2E7/near/273449615
cescoffier
approved these changes
Feb 28, 2022
geoand
force-pushed
the
jib-remote-dev
branch
from
bd4568c to
36674bd
Compare
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue without this is that Jib overwrites the owner
of the working directory and sets it to root.
With this fix, we add a faux layer that simply
reverts the owner back to the default when the
default base image is used.
Originally discussed at: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/remote.20dev.20in.202.2E7/near/273449615