Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redpanda image name check #24003

Merged

Conversation

ozangunalp
Copy link
Contributor

Fixes #23978

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9162ec5

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/kafka-client/deployment 
! Skipped: docs extensions/kafka-streams/deployment extensions/smallrye-reactive-messaging-kafka/deployment and 13 more

📦 extensions/kafka-client/deployment

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-kafka-client-deployment: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/DevServicesKafkaProcessor.java

@ozangunalp ozangunalp force-pushed the remove_redpanda_image_name_check branch from 9162ec5 to eb221b0 Compare February 28, 2022 10:13
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation might need to be updated.

@gsmet
Copy link
Member

gsmet commented Feb 28, 2022

Is it backportable or not?

@cescoffier
Copy link
Member

Technically it is, but reason we have lifted this is because we have now the support of 'bare' kafka. Is it in 2.7 already? @ozangunalp ?

@gastaldi gastaldi merged commit b4e0afd into quarkusio:main Feb 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 28, 2022
@gastaldi
Copy link
Contributor

Ah just saw @cescoffier's comment about the need to update the documentation. Mind providing a separate PR with that @ozangunalp ?

@ozangunalp
Copy link
Contributor Author

@gsmet No need to backport, it is not in 2.7. @gastaldi my bad, I was late to respond, I'll make the doc changes in another PR.

@ozangunalp ozangunalp deleted the remove_redpanda_image_name_check branch February 28, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka dev services can not be used with redpanda images from outside of DockerHub
4 participants