Unwrap InvocationTargetException thrown by QuarkusTest*Callback #23989
Conversation
| Map.Entry<Class<?>, ?> tuple = createQuarkusTestMethodContextTuple(context); | ||
| afterEachCallback.getClass().getMethod("afterEach", tuple.getKey()) | ||
| .invoke(afterEachCallback, tuple.getValue()); | ||
| } |
There was a problem hiding this comment.
Running this outside of the TCCL restoration block looked wrong, so I moved it inside.
There was a problem hiding this comment.
Hm... Not sure about this... Did you see an issue with the existing code?
There was a problem hiding this comment.
Not an actual one, but compare it with this:
https://github.com/quarkusio/quarkus/blob/2.7.2.Final/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java#L407
Why should the TCCL only be restored if there is an exception in a beforeEachCallback, but not if there is an exception in an afterEachCallback? Doesn't make sense to me.
There was a problem hiding this comment.
PS: afterAll also restores the TCCL just like beforeEach. Same happens for beforeClassCallback. 🤷♂️
There was a problem hiding this comment.
This change looks right to me
|
I'll add the backport label because I think that TCCL thing is a bug (rare though). |
Improves readability when you have e.g. a custom callback that validates something.
Some methods are only allowed to throw
Exeption, notThrowable, hence the cause type check.