Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage tabs for kotlin DSL in gradle documentation #23953

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

glefloch
Copy link
Member

This leverage tabs in gradle documentation and add kotlin dsl example.

[source,groovy,subs=attributes+]
----
test {
systemProperty "quarkus.test.profile", "foo" <1>
}
----

or, if you use the Gradle Kotlin DSL:
<1> The `foo` configuration profile will be used to run the tests.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet I duplicate the <1> note on both tabs, otherwise it wasn't appearing. Is there a way to avoid duplicating that part?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's how it should be done. The note is attached to the source block so you can't do it another way.

@glefloch glefloch requested review from gsmet and gastaldi February 25, 2022 08:15
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Happy to see others use it :).

@gastaldi gastaldi merged commit 5919bee into quarkusio:main Feb 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 25, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants