Warning messages for unknown build time properties

core/deployment/src/main/java/io/quarkus/deployment/configuration/BuildTimeConfigurationReader.java

@@ -327,9 +327,9 @@ final class ReadOperation {
         final Set<String> processedNames = new HashSet<>();
 
         final Map<Class<?>, Object> objectsByClass = new HashMap<>();
-        final Map<String, String> specifiedRunTimeDefaultValues = new TreeMap<>();
-        final Map<String, String> buildTimeRunTimeVisibleValues = new TreeMap<>();
         final Map<String, String> allBuildTimeValues = new TreeMap<>();
+        final Map<String, String> buildTimeRunTimeVisibleValues = new TreeMap<>();
+        final Map<String, String> specifiedRunTimeDefaultValues = new TreeMap<>();
 
         final Map<ConverterType, Converter<?>> convByType = new HashMap<>();
 
@@ -362,10 +362,10 @@ ReadResult run() {
                 nameBuilder.setLength(0);
             }
 
-            Set<String> registeredRoots = allRoots.stream().map(RootDefinition::getPrefix).collect(toSet());
-            // sweep-up
             SmallRyeConfig runtimeDefaultsConfig = getConfigForRuntimeDefaults();
-            final Set<String> allProperties = getAllProperties(registeredRoots);
+            Set<String> registeredRoots = allRoots.stream().map(RootDefinition::getPrefix).collect(toSet());
+            Set<String> allProperties = getAllProperties(registeredRoots);
+            Set<String> unknownBuildProperties = new HashSet<>();
             for (String propertyName : allProperties) {
                 if (propertyName.equals(ConfigSource.CONFIG_ORDINAL)) {
                     continue;
@@ -449,6 +449,7 @@ ReadResult run() {
                         if (configValue.getValue() != null) {
                             specifiedRunTimeDefaultValues.put(configValue.getNameProfiled(), configValue.getValue());
                         }
+                        continue;
                     }
                     // also check for the bootstrap properties since those need to be added to specifiedRunTimeDefaultValues as well
                     ni.goToStart();
@@ -459,7 +460,11 @@ ReadResult run() {
                         if (configValue.getValue() != null) {
                             specifiedRunTimeDefaultValues.put(configValue.getNameProfiled(), configValue.getValue());
                         }
+                        continue;
                     }
+
+                    // If we reach here it means we were not able to match the property (and it shares roots namespace)
+                    unknownBuildProperties.add(propertyName);
                 } else {
                     // it's not managed by us; record it
                     ConfigValue configValue = withoutExpansion(() -> runtimeDefaultsConfig.getConfigValue(propertyName));
@@ -478,6 +483,7 @@ ReadResult run() {
             for (ConfigClassWithPrefix mapping : buildTimeMappings) {
                 Set<String> mappedProperties = ConfigMappings.mappedProperties(mapping, allProperties);
                 for (String property : mappedProperties) {
+                    unknownBuildProperties.remove(property);
                     ConfigValue value = config.getConfigValue(property);
                     if (value != null && value.getRawValue() != null) {
                         allBuildTimeValues.put(property, value.getRawValue());
@@ -489,6 +495,7 @@ ReadResult run() {
             for (ConfigClassWithPrefix mapping : buildTimeRunTimeMappings) {
                 Set<String> mappedProperties = ConfigMappings.mappedProperties(mapping, allProperties);
                 for (String property : mappedProperties) {
+                    unknownBuildProperties.remove(property);
                     ConfigValue value = config.getConfigValue(property);
                     if (value != null && value.getRawValue() != null) {
                         allBuildTimeValues.put(property, value.getRawValue());
@@ -501,6 +508,7 @@ ReadResult run() {
             for (ConfigClassWithPrefix mapping : runTimeMappings) {
                 Set<String> mappedProperties = ConfigMappings.mappedProperties(mapping, allProperties);
                 for (String property : mappedProperties) {
+                    unknownBuildProperties.remove(property);
                     ConfigValue value = config.getConfigValue(property);
                     if (value != null && value.getRawValue() != null) {
                         specifiedRunTimeDefaultValues.put(property, value.getRawValue());
@@ -521,6 +529,7 @@ ReadResult run() {
                     .setBuildTimeMappings(buildTimeMappings)
                     .setBuildTimeRunTimeMappings(buildTimeRunTimeMappings)
                     .setRunTimeMappings(runTimeMappings)
+                    .setUnknownBuildProperties(unknownBuildProperties)
                     .createReadResult();
         }
 
@@ -940,6 +949,8 @@ public static final class ReadResult {
         final List<ConfigClassWithPrefix> runTimeMappings;
         final Map<Class<?>, ConfigClassWithPrefix> allMappings;
 
+        final Set<String> unknownBuildProperties;
+
         public ReadResult(final Builder builder) {
             this.objectsByClass = builder.getObjectsByClass();
 
@@ -961,6 +972,8 @@ public ReadResult(final Builder builder) {
             this.buildTimeRunTimeMappings = builder.getBuildTimeRunTimeMappings();
             this.runTimeMappings = builder.getRunTimeMappings();
             this.allMappings = mappingsToMap(builder);
+
+            this.unknownBuildProperties = builder.getUnknownBuildProperties();
         }
 
         private static Map<Class<?>, RootDefinition> rootsToMap(Builder builder) {
@@ -1045,6 +1058,10 @@ public Map<Class<?>, ConfigClassWithPrefix> getAllMappings() {
             return allMappings;
         }
 
+        public Set<String> getUnknownBuildProperties() {
+            return unknownBuildProperties;
+        }
+
         public Object requireObjectForClass(Class<?> clazz) {
             Object obj = objectsByClass.get(clazz);
             if (obj == null) {
@@ -1067,6 +1084,7 @@ static class Builder {
             private List<ConfigClassWithPrefix> buildTimeMappings;
             private List<ConfigClassWithPrefix> buildTimeRunTimeMappings;
             private List<ConfigClassWithPrefix> runTimeMappings;
+            private Set<String> unknownBuildProperties;
 
             Map<Class<?>, Object> getObjectsByClass() {
                 return objectsByClass;
@@ -1185,6 +1203,15 @@ Builder setRunTimeMappings(final List<ConfigClassWithPrefix> runTimeMappings) {
                 return this;
             }
 
+            Set<String> getUnknownBuildProperties() {
+                return unknownBuildProperties;
+            }
+
+            Builder setUnknownBuildProperties(final Set<String> unknownBuildProperties) {
+                this.unknownBuildProperties = unknownBuildProperties;
+                return this;
+            }
+
             ReadResult createReadResult() {
                 return new ReadResult(this);
             }

core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java

@@ -67,6 +67,7 @@
 import io.quarkus.runtime.LaunchMode;
 import io.quarkus.runtime.annotations.ConfigPhase;
 import io.quarkus.runtime.annotations.StaticInitSafe;
+import io.quarkus.runtime.configuration.ConfigDiagnostic;
 import io.quarkus.runtime.configuration.ConfigRecorder;
 import io.quarkus.runtime.configuration.ConfigUtils;
 import io.quarkus.runtime.configuration.ProfileManager;
@@ -140,6 +141,9 @@ void generateConfigClass(
             List<RunTimeConfigBuilderBuildItem> runTimeConfigBuilders)
             throws IOException {
 
+        reportUnknownBuildProperties(launchModeBuildItem.getLaunchMode(),
+                configItem.getReadResult().getUnknownBuildProperties());
+
         if (liveReloadBuildItem.isLiveReload()) {
             return;
         }
@@ -192,7 +196,17 @@ void generateConfigClass(
                 .run();
     }
 
-    private List<String> getAdditionalBootstrapConfigSourceProviders(
+    private static void reportUnknownBuildProperties(LaunchMode launchMode, Set<String> unknownBuildProperties) {
+        // So it only reports during the build, because it is very likely that the property is available in runtime
+        // and, it will be caught by the RuntimeConfig and log double warnings
+        if (!launchMode.isDevOrTest()) {
+            for (String unknownProperty : unknownBuildProperties) {
+                ConfigDiagnostic.unknown(unknownProperty);
+            }
+        }
+    }
+
+    private static List<String> getAdditionalBootstrapConfigSourceProviders(
             List<AdditionalBootstrapConfigSourceProviderBuildItem> additionalBootstrapConfigSourceProviders) {
         if (additionalBootstrapConfigSourceProviders.isEmpty()) {
             return Collections.emptyList();

core/test-extension/deployment/src/test/java/io/quarkus/extest/UnknownBuildConfigTest.java

@@ -0,0 +1,37 @@
+package io.quarkus.extest;
+
+import static java.util.Arrays.asList;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.util.List;
+import java.util.Optional;
+import java.util.logging.Level;
+import java.util.logging.LogRecord;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.ProdBuildResults;
+import io.quarkus.test.ProdModeTestResults;
+import io.quarkus.test.QuarkusProdModeTest;
+
+public class UnknownBuildConfigTest {
+    @RegisterExtension
+    static final QuarkusProdModeTest TEST = new QuarkusProdModeTest()
+            .setLogRecordPredicate(record -> record.getLevel().intValue() >= Level.WARNING.intValue())
+            .setExpectExit(true);
+
+    @ProdBuildResults
+    private ProdModeTestResults prodModeTestResults;
+
+    @Test
+    void unknownBuildConfig() {
+        List<LogRecord> logRecords = prodModeTestResults.getRetainedBuildLogRecords();
+
+        Optional<LogRecord> unknownBuildKey = logRecords.stream()
+                .filter(logRecord -> asList(logRecord.getParameters()).contains("quarkus.build.unknown.prop"))
+                .findFirst();
+        assertTrue(unknownBuildKey.isPresent());
+        assertTrue(unknownBuildKey.get().getMessage().startsWith("Unrecognized configuration key"));
+    }
+}

core/test-extension/deployment/src/test/java/io/quarkus/extest/UnknownConfigTest.java

@@ -1,6 +1,7 @@
 package io.quarkus.extest;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.Set;
@@ -28,6 +29,7 @@ public class UnknownConfigTest {
                 Set<String> properties = logRecords.stream().flatMap(
                         logRecord -> Stream.of(logRecord.getParameters())).map(Object::toString).collect(Collectors.toSet());
                 assertTrue(properties.contains("quarkus.unknown.prop"));
+                assertFalse(properties.contains("quarkus.build.unknown.prop"));
             });
 
     @Inject

core/test-extension/runtime/src/main/java/io/quarkus/extest/runtime/config/unknown/UnknownBuildPropertyConfigSourceFactory.java

@@ -0,0 +1,25 @@
+package io.quarkus.extest.runtime.config.unknown;
+
+import static java.util.Collections.emptyList;
+
+import java.util.List;
+import java.util.Map;
+
+import org.eclipse.microprofile.config.spi.ConfigSource;
+
+import io.smallrye.config.ConfigSourceContext;
+import io.smallrye.config.ConfigSourceFactory;
+import io.smallrye.config.ConfigValue;
+import io.smallrye.config.PropertiesConfigSource;
+
+public class UnknownBuildPropertyConfigSourceFactory implements ConfigSourceFactory {
+    @Override
+    public Iterable<ConfigSource> getConfigSources(final ConfigSourceContext context) {
+        ConfigValue value = context.getValue("skip.build.sources");
+        if (value.getValue() == null || value.getValue().equals("false")) {
+            return List.of(new PropertiesConfigSource(Map.of("quarkus.build.unknown.prop", "value"), "", 100));
+        } else {
+            return emptyList();
+        }
+    }
+}

core/test-extension/runtime/src/main/resources/META-INF/services/io.smallrye.config.ConfigSourceFactory

@@ -1 +1,2 @@
 io.quarkus.extest.runtime.config.rename.RenameConfigSourceFactory
+io.quarkus.extest.runtime.config.unknown.UnknownBuildPropertyConfigSourceFactory