Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernate Validator - Allow setting the expression language feature level #23877

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 22, 2022

I only exposed the constraint one and not the custom violation one as I
think it is bad practice to globally change the custom violation one.

Fix #23838

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents. Looks good otherwise.

@gsmet gsmet force-pushed the hv-expression-language branch from 8401775 to 751d336 Compare February 28, 2022 17:54
@gsmet
Copy link
Member Author

gsmet commented Feb 28, 2022

@yrodiere I merged your suggestions.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2022

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 8d57606

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build ⚠️ Check → Logs Raw logs
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 751d336

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/hibernate-validator/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 222 more

📦 extensions/hibernate-validator/runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-hibernate-validator: File '/home/runner/work/quarkus/quarkus/extensions/hibernate-validator/runtime/src/main/java/io/quarkus/hibernate/validator/runtime/HibernateValidatorBuildTimeConfig.java' has not been previously formatted. Please format file and commit before running validation!

…evel

I only exposed the constraint one and not the custom violation one as I
think it is bad practice to globally change the custom violation one.

Fix quarkusio#23838
@yrodiere yrodiere force-pushed the hv-expression-language branch from 751d336 to 780d683 Compare March 1, 2022 07:25
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and applied autoformat. LGTM!

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 1, 2022
@geoand geoand merged commit afcdc11 into quarkusio:main Mar 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 1, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 1, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java validation errors in graphql
3 participants