-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hibernate Validator - Allow setting the expression language feature level #23877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents. Looks good otherwise.
.../src/main/java/io/quarkus/hibernate/validator/runtime/HibernateValidatorBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/quarkus/hibernate/validator/runtime/HibernateValidatorBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
8401775
to
751d336
Compare
@yrodiere I merged your suggestions. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 751d336
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/hibernate-validator/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 222 more 📦 extensions/hibernate-validator/runtime✖ |
…evel I only exposed the constraint one and not the custom violation one as I think it is bad practice to globally change the custom violation one. Fix quarkusio#23838
751d336
to
780d683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and applied autoformat. LGTM!
I only exposed the constraint one and not the custom violation one as I
think it is bad practice to globally change the custom violation one.
Fix #23838