Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify sql-load-script must be in the application resources #23863

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

yrodiere
Copy link
Member

Fixes #23574

Actually, the bug was fixed in #23692 , but since that PR was about a very low-level issue, we did not add a non-regression test for the problem that was originally noticed in the Hibernate ORM extension.

This adds the non-regression test, and clarifies the documentation.

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Feb 22, 2022
@yrodiere yrodiere changed the title Sql load script location Clarify sql-load-script must be in the application resources Feb 22, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 22, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c608b82

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 90 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.sql_load_script.AbsoluteFileSystemPathSqlLoadScriptTestCase. line 48 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual throwable to be an instance of:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 90 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.sql_load_script.AbsoluteFileSystemPathSqlLoadScriptTestCase. line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting throwable message:

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 90 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.sql_load_script.AbsoluteFileSystemPathSqlLoadScriptTestCase. line 48 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual throwable to be an instance of:

@yrodiere yrodiere force-pushed the sql-load-script-location branch from c608b82 to 368dc73 Compare February 22, 2022 11:18
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 22, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 368dc73

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.InjectQuarkusAppPropertiesDevModeTest.main line 19 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 90 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.sql_load_script.AbsoluteFileSystemPathSqlLoadScriptTestCase. line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting throwable message:

@yrodiere yrodiere force-pushed the sql-load-script-location branch 2 times, most recently from a99690f to f5b51ad Compare February 22, 2022 16:32
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 22, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f5b51ad

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 90 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.sql_load_script.AbsoluteFileSystemPathSqlLoadScriptTestCase. line 50 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting throwable message:

@yrodiere yrodiere force-pushed the sql-load-script-location branch from f5b51ad to a93f367 Compare February 23, 2022 08:02
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Feb 23, 2022
@yrodiere yrodiere force-pushed the sql-load-script-location branch from a93f367 to 63f5382 Compare February 23, 2022 08:03
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 23, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 63f5382

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/bootstrap/app-model 
! Skipped: core/deployment core/launcher core/runtime and 701 more

📦 independent-projects/bootstrap/app-model

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-bootstrap-app-model: Imports are not sorted in /home/runner/work/quarkus/quarkus/independent-projects/bootstrap/app-model/src/test/java/io/quarkus/paths/JarPathTreeTest.java

@yrodiere yrodiere force-pushed the sql-load-script-location branch from 63f5382 to b1889d6 Compare February 23, 2022 08:17
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 23, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b1889d6

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 90 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.sql_load_script.SqlLoadScriptAbsoluteFileSystemPathUnescapedOnWindowsTestCase. line 62 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting throwable message:

…te path (on the FS) to a resource file fails
…the application resources, not on the filesystem
@yrodiere yrodiere force-pushed the sql-load-script-location branch from b1889d6 to 7eade13 Compare February 23, 2022 09:48
@gsmet gsmet merged commit 731b9a4 into quarkusio:main Feb 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 28, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Feb 28, 2022
@yrodiere yrodiere deleted the sql-load-script-location branch May 31, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus.hibernate-orm.sql-load-script works with relative path but ignores absolute path
2 participants